[prometheus-blackbox-exporter] Enable annotations for Secret #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dasha Bulanova <[email protected]>
DashaBulanova
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
aabf
approved these changes
Mar 28, 2024
monotek
requested changes
Apr 2, 2024
Looks much better ) thank you Co-authored-by: André Bauer <[email protected]> Signed-off-by: Darya Bulanova <[email protected]>
Signed-off-by: Darya Bulanova <[email protected]>
monotek
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR introduces a new ability to set annotations for the Secret.
@desaintmartin, @gianrubio, @rsotnychenko, @monotek, mentioning you as owners as instructed in the PR template.
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])