[prometheus-elasticsearch-exporter] add ability to customize apiversion for pod/service monitor #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashmi Chandrashekar <[email protected]>
rashmichandrashekar
requested review from
desaintmartin and
zeritti
as code owners
DrFaust92
suggested changes
Mar 23, 2024
charts/prometheus-elasticsearch-exporter/templates/podmonitor.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Rashmi Chandrashekar <[email protected]>
Signed-off-by: Rashmi Chandrashekar <[email protected]>
rashmichandrashekar
changed the title
Signed-off-by: Rashmi Chandrashekar <[email protected]>
|
gentle ping @DrFaust92 @desaintmartin @zeritti. Please take a look and let me know if you see any concerns. Thanks! |
DrFaust92
approved these changes
Mar 27, 2024
zeritti
requested changes
Mar 27, 2024
There was a problem hiding this comment.
Thank you, @rashmichandrashekar, for your PR. Please, see my comments below.
charts/prometheus-elasticsearch-exporter/templates/podmonitor.yaml
Outdated
Show resolved
Hide resolved
charts/prometheus-elasticsearch-exporter/templates/servicemonitor.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Rashmi Chandrashekar <[email protected]>
zeritti
changed the title
zeritti
approved these changes
Mar 27, 2024
|
thanks @zeritti. Will you be able to merge this and create a release too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
Adding support for customizing api version for pod/service monitor as it is useful for support with Azure managed prometheus that looks for pod/service monitors in its own api group
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])