Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update dependency ubuntu to v22 #4364

Merged
merged 1 commit into from
Mar 17, 2024
Merged

[CI] Update dependency ubuntu to v22 #4364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-codeowners.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Check CODEOWNERS
on: pull_request
jobs:
build:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this to ubuntu-latest? The version really doesn’t matter for this workflow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would als prefer lastest, but I through there was a reason for pin the version. I didn't know each historic decision

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would favor explicit updates instead of using latest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's not constant across all workflows

helm-charts/.github/workflows/superlinter.yml

Line 11 in 8995925

runs-on: ubuntu-latest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than I would prefer to have the fixed version everywhere.

Imho it's not more maintenance as renovate bot should take care of it.

Greetings from kubecon😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get together at kubecon? If you want, write me at cncf slack or linkedin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do :)

steps:
- name: Checkout Code
uses: actions/checkout@v4
Expand Down
Loading