[prometheus-blackbox-exporter] fix: only template env if .Values.extraEnv is specified #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aEnv is specified Signed-off-by: Adrian Berger <[email protected]>
adberger
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
|
not stale |
Signed-off-by: André Bauer <[email protected]>
monotek
approved these changes
Apr 22, 2024
agree.. |
wilfriedroset
pushed a commit
to wilfriedroset/helm-charts
that referenced
this pull request
May 8, 2024
…aEnv is specified (prometheus-community#4354) Signed-off-by: Adrian Berger <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Currently when
.Values.extraEnvis omitted, env is still templated in the deploymen spec.ArgoCDs new Server-Side Diff is not happy about it.
This PR solves this issue.
Checklist
[prometheus-couchdb-exporter])