Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-node-exporter] Add Variables for Proxy Endpoints Arg and Health Check Ports #4325

Merged
merged 6 commits into from
Mar 5, 2024
Merged

[prometheus-node-exporter] Add Variables for Proxy Endpoints Arg and Health Check Ports #4325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8249846
added vars for proxy endpoints and also for reading and health checks
nfrazier08 Mar 1, 2024
c18ddcb
remove healthz port
nfrazier08 Mar 4, 2024
7893262
update ds with no duplicate port for healthz
nfrazier08 Mar 4, 2024
e56a90b
disable kubeproxy from testing
nfrazier08 Mar 4, 2024
0603790
fix comments in values files
nfrazier08 Mar 5, 2024
fa8f630
Merge branch 'main' into add_var_for_hardcoded_port
nfrazier08 Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-node-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ keywords:
- prometheus
- exporter
type: application
version: 4.30.3
version: 4.31.0
appVersion: 1.7.0
home: https://github.com/prometheus/node_exporter/
sources:
Expand Down
9 changes: 6 additions & 3 deletions charts/prometheus-node-exporter/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ spec:
{{- end }}
- --secure-listen-address=:{{ .Values.service.port}}
- --upstream=http://127.0.0.1:{{ $servicePort }}/
- --proxy-endpoints-port=8888
- --proxy-endpoints-port={{ .Values.kubeRBACProxy.proxyEndpointsPort }}
- --config-file=/etc/kube-rbac-proxy-config/config-file.yaml
volumeMounts:
- name: kube-rbac-proxy-config
Expand All @@ -205,12 +205,15 @@ spec:
{{- if .Values.kubeRBACProxy.enableHostPort }}
hostPort: {{ .Values.service.port }}
{{- end }}
- containerPort: 8888
- containerPort: {{ .Values.kubeRBACProxy.proxyEndpointsPort }}
{{- if .Values.kubeRBACProxy.enableProxyEndpointsHostPort }}
hostPort: {{ .Values.kubeRBACProxy.proxyEndpointsPort }}
{{- end }}
name: "http-healthz"
readinessProbe:
httpGet:
scheme: HTTPS
port: 8888
port: {{ .Values.kubeRBACProxy.proxyEndpointsPort }}
path: healthz
nfrazier08 marked this conversation as resolved.
Show resolved Hide resolved
initialDelaySeconds: 5
timeoutSeconds: 5
Expand Down
6 changes: 6 additions & 0 deletions charts/prometheus-node-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ kubeRBACProxy:
# Configure a hostPort. If true, hostPort will be enabled in the container and set to service.port.
enableHostPort: false

# Configure Proxy Endpoints Port
# This is the port being probed for readiness
proxyEndpointsPort: 8888
# Configure a hostPort. If true, hostPort will be enabled in the container and set to proxyEndpointsPort.
enableProxyEndpointsHostPort: false

resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
Expand Down
Loading