Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-snmp-exporter] configmap-reload change image to quay.io #4304

Merged
merged 7 commits into from
Feb 29, 2024
Merged

[prometheus-snmp-exporter] configmap-reload change image to quay.io #4304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d458c78
Change SNMP exporter configmap-reload image to quay.io
Feb 27, 2024
5e49af5
bump chart version to 3.0.1
Feb 27, 2024
2e49a0e
Change chart version to 4.0.0
Feb 28, 2024
4b8ad6f
Add version 4.0.0 notes to readme file of snmp exporter
Feb 28, 2024
35f1032
Change Config Reloader Args in Deployment & Deamonset
Feb 28, 2024
137fdd2
Merge branch 'main' into main
MohammadrezaTavakoli Feb 28, 2024
f765bdb
Merge branch 'main' into main
walker-tom Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-snmp-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: Prometheus SNMP Exporter
name: prometheus-snmp-exporter
version: 3.1.1
version: 4.0.0
appVersion: v0.24.1
home: https://github.com/prometheus/snmp_exporter
sources:
Expand Down
4 changes: 4 additions & 0 deletions charts/prometheus-snmp-exporter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ This version changes the `serviceMonitor.namespace` value from `monitoring` to t
This version upgrades snmp-exporter version to 0.24.1, which introduces breaking change to configuration format.
See [Module and Auth Split Migration](https://github.com/prometheus/snmp_exporter/blob/main/auth-split-migration.md) for more details.

### To 4.0.0

This version contain major changes & The [configmap-reload](https://github.com/jimmidyson/configmap-reload) container was replaced by the [prometheus-config-reloader](https://github.com/prometheus-operator/prometheus-operator/tree/main/cmd/prometheus-config-reloader).

## Configuration

See [Customizing the Chart Before Installing](https://helm.sh/docs/intro/using_helm/#customizing-the-chart-before-installing). To see all configurable options with detailed comments, visit the chart's [values.yaml](./values.yaml), or run these configuration commands:
Expand Down
4 changes: 2 additions & 2 deletions charts/prometheus-snmp-exporter/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ spec:
image: "{{ .Values.configmapReload.image.repository }}:{{ .Values.configmapReload.image.tag }}"
imagePullPolicy: "{{ .Values.configmapReload.image.pullPolicy }}"
args:
- --volume-dir=/etc/config
- --webhook-url=http://localhost:{{ .Values.service.port }}/-/reload
- --watched-dir=/etc/config
- --reload-url=http://localhost:{{ .Values.service.port }}/-/reload
resources:
{{ toYaml .Values.configmapReload.resources | indent 12 }}
volumeMounts:
Expand Down
4 changes: 2 additions & 2 deletions charts/prometheus-snmp-exporter/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ spec:
image: "{{ .Values.configmapReload.image.repository }}:{{ .Values.configmapReload.image.tag }}"
imagePullPolicy: "{{ .Values.configmapReload.image.pullPolicy }}"
args:
- --volume-dir=/etc/config
- --webhook-url=http://localhost:{{ .Values.service.port }}/-/reload
- --watched-dir=/etc/config
- --reload-url=http://localhost:{{ .Values.service.port }}/-/reload
resources:
{{ toYaml .Values.configmapReload.resources | indent 12 }}
volumeMounts:
Expand Down
4 changes: 2 additions & 2 deletions charts/prometheus-snmp-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ configmapReload:
## configmap-reload container image
##
image:
repository: jimmidyson/configmap-reload
tag: v0.5.0
repository: quay.io/prometheus-operator/prometheus-config-reloader
tag: v0.71.2
pullPolicy: IfNotPresent

## configmap-reload resource requests and limits
Expand Down
Loading