[kube-prometheus-stack] add namespaced roles for Prometheus/Operator #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petenorth
reviewed
Feb 23, 2024
charts/kube-prometheus-stack/templates/prometheus-operator/clusterrole.yaml
Outdated
Show resolved
Hide resolved
jkroepke
changed the title
jkroepke
force-pushed
the
namespaces
branch
3 times, most recently
from
be06bec to
5d0d544
Compare
Signed-off-by: Jan-Otto Kröpke <[email protected]>
jkroepke
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Signed-off-by: Jan-Otto Kröpke <[email protected]>
…n and fix label aggregation in TargetDown alert Signed-off-by: Jan-Otto Kröpke <[email protected]>
|
@jkroepke do you feel like you could try to merge main here? I think the PR is quite good :) |
|
tbh, no idea. half year ago, totally out of context here and limited time to test it. 😅 |
|
No worries I'm trying to clean up my list of PRs to review so it's fine if we keep it open :) |
|
Hey, @jkroepke! I see that this PR was not updated for a while. It is a great PR for improving the security, I am currently start working on the same improvement. Will you have time to update? I can take it over and add this feature in the new PR |
|
Please take over! I'm happy to take an review over it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])