[prometheus-statsd-exporter] fix HPA target reordering problem #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-jeong
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
gavin-jeong
force-pushed
the
hpa-ordering
branch
from
c36560c to
516fe0d
Compare
gavin-jeong
changed the title
|
@gavin-jeong the title is mention kube-prometheus-stack, but you commit for prometheus-statsd-exporter? |
gavin-jeong
changed the title
Signed-off-by: gavin.jeong <[email protected]>
gavin-jeong
force-pushed
the
hpa-ordering
branch
from
516fe0d to
0cd28c8
Compare
|
Completed in #4171. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some bug that Kubernetes ordering HPA target. kubernetes/kubernetes#74099
It makes diff every time when we deploy the chart with gitops based tools like ArgoCD.
This PR is for changing its order to prevent the diff action.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])