Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Inhibit InfoInhibitor early #4081

Closed

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Dec 11, 2023

What this PR does / why we need it

This avoid receiving InfoInhibitor from AlertmanagerConfig

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@sathieu
Copy link
Contributor Author

sathieu commented Dec 11, 2023

This avoid receiving InfoInhibitor from AlertmanagerConfig

Signed-off-by: Mathieu Parent <[email protected]>
@sathieu sathieu force-pushed the inhibit_InfoInhibitor_early branch from db240f5 to 303198f Compare December 11, 2023 14:49
@GMartinez-Sisti
Copy link
Member

GMartinez-Sisti commented Dec 12, 2023

Thanks for your contribution @sathieu, but it looks like a duplicate of #3964. There is a different change here though. Please sync with @ANGkeith.

@sathieu
Copy link
Contributor Author

sathieu commented Dec 12, 2023

Yes @GMartinez-Sisti This is the same change. I just removed the now unneeded route.

@GMartinez-Sisti
Copy link
Member

#3964 was merged. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants