[kube-prometheus-stack] fix missing pod label for etcdInsufficientMem… #4031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangaiser
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
sebastiangaiser
force-pushed
the
main
branch
from
fb7f042 to
24fdf67
Compare
sebastiangaiser
force-pushed
the
main
branch
from
24fdf67 to
5d9e4a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix missing pod label for etcdInsufficientMembers
When the pod label is not in the without block, the alert is firing with 'etcd cluster kube-etcd: insufficient members (0).'
What this PR does / why we need it
Fixes false positive alert for
etcdInsufficientMembersWhich issue this PR fixes
Special notes for your reviewer
Tear down 1 controlplane for e.g. Kubernetes update and etcd should be "fine" but the alert was firing.
Checklist
[prometheus-couchdb-exporter])