Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] - Sync from kube-prometheus #4010

Closed
wants to merge 2 commits into from

Conversation

eg-ayoub
Copy link

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • [ x ] DCO signed
  • [ x ] Chart Version bumped
  • [ x ] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@eg-ayoub
Copy link
Author

not sure if we want the k8s.rules files, I will delete them if they are unwanted.
ps: this was resulting of a sync_prometheus_rules.py execution.

@Daniel-Vaz
Copy link

Daniel-Vaz commented Nov 15, 2023

Note that the underscore in the manifest names results in failed applies on the clusters:

PrometheusRule.monitoring.coreos.com "kps-kube-prometheus-stack-k8s.rules.container_resource" is invalid: metadata.name: Invalid value: "kps-kube-prometheus-stack-k8s.rules.container_resource": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

@eg-ayoub
Copy link
Author

eg-ayoub commented Nov 15, 2023

seems like these groups were added here prometheus-operator/kube-prometheus@5e2890e
so they're automatically added through the python script.
I don't think I should just delete them.
I'm investigating where these came from.
EDIT: found them, kubernetes-monitoring/kubernetes-mixin@d1a28fc
so the groups here are getting split into files, maybe they should remain as one.

@GMartinez-Sisti
Copy link
Member

@eg-ayoub this PR #3883 will do the same as this one. Maybe close this and track that one 👼 ?

@eg-ayoub
Copy link
Author

@GMartinez-Sisti noted, thanks a lot!

@eg-ayoub eg-ayoub closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants