[prometheus-rabbitmq-exporter] add target labels support #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alex-souslik-hs <[email protected]>
alex-souslik-hs
requested review from
desaintmartin,
Juanchimienti and
monotek
as code owners
Signed-off-by: Alex Souslik <[email protected]>
monotek
requested changes
Nov 16, 2023
Signed-off-by: alex-souslik-hs <[email protected]>
alex-souslik-hs
force-pushed
the
main
branch
from
bc20e46 to
8b03153
Compare
monotek
approved these changes
Jan 8, 2024
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…community#3939) * [prometheus-rabbitmq-exporter] add target labels support Signed-off-by: alex-souslik-hs <[email protected]> * change if to with Signed-off-by: alex-souslik-hs <[email protected]> --------- Signed-off-by: alex-souslik-hs <[email protected]> Signed-off-by: Alex Souslik <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR allows setting additional target labels for the
ServiceMonitorand setting the labels themselves in the monitored service.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])