Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-snmp-exporter] add action=replace to metricsRelabelings #3858

Conversation

thinkmassive
Copy link
Contributor

What this PR does / why we need it

This (default) parameter is automatically added by k8s, causing the in-cluster object to differ from the manifest created by this chart. This discrepancy causes GitOps tooling to consider the resource out of date.

Which issue this PR fixes

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

This (default) parameter is automatically added by k8s, causing the in-cluster
object to differ from the manifest created by this chart. This discrepancy
causes GitOps tooling to consider the resource out of date, as described in
prometheus-community#3626

Signed-off-by: Alex Miller <[email protected]>
@thinkmassive thinkmassive requested a review from xiu as a code owner October 3, 2023 19:54
Copy link
Contributor

@xiu xiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xiu xiu merged commit 57c9e02 into prometheus-community:main Oct 3, 2023
4 checks passed
@thinkmassive thinkmassive deleted the snmp-servicemonitor-metricsrelabeling-action branch October 3, 2023 20:40
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request Mar 20, 2024
…rometheus-community#3858)

This (default) parameter is automatically added by k8s, causing the in-cluster
object to differ from the manifest created by this chart. This discrepancy
causes GitOps tooling to consider the resource out of date, as described in
prometheus-community#3626

Signed-off-by: Alex Miller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-snmp-exporter] GitOps keeps getting OutOfSync due to missing param in ServiceMonitor endpoint
2 participants