[prometheus] Add permission on endpointslices in cluster role #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeritti <[email protected]>
Signed-off-by: zeritti <[email protected]>
zeritti
requested review from
gianrubio,
naseemkullah,
Xtigyro and
zanhsieh
as code owners
zanhsieh
approved these changes
Oct 2, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…heus-community#3840) * Add permission on endpointslices in cluster role Signed-off-by: zeritti <[email protected]> * Bump chart version Signed-off-by: zeritti <[email protected]> --------- Signed-off-by: zeritti <[email protected]> Co-authored-by: MH <[email protected]>
|
kube-prometheus-stack need this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The cluster role for cluster-wide service discovery does not grant a permission on EndpointSlices (stable since 1.21, supported as a role type by Prometheus since 2.21). This PR adds that permission.
Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])