Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-state-metrics] Add option to attach sidecar container #3834

Conversation

dominic-paul-92
Copy link
Contributor

@dominic-paul-92 dominic-paul-92 commented Sep 28, 2023

What this PR does / why we need it

Support to attach a sidecar container(s), to the kube state metrics pod.

Which issue this PR fixes

This is primarily useful for having a standalone elastic agent run as sidecar container.

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@dominic-paul-92 dominic-paul-92 marked this pull request as ready for review September 28, 2023 09:56
@dotdc
Copy link
Member

dotdc commented Oct 4, 2023

Hi @dominic-paul-92,
Thank you for the pull request!
Unfortunately, I will have to close it as I just merged #3861, which is the same change using containers instead of sidecars.

@dotdc dotdc closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kube-state-metrics] Support elastic agent sidecar
2 participants