Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-adapter] Add a name to the Service object (KIA0601) #3808

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

PauloFerreira25
Copy link
Contributor

What this PR does / why we need it

Fixes the KIA0601 error

Special notes for your reviewer

is just the name of the service

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@@ -1,6 +1,6 @@
apiVersion: v1
name: prometheus-adapter
version: 4.5.0
version: 4.5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to bump the version

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@cesium147
Copy link

Bump.
Service port name need for correct work ServiceMonitor CR!

Example, i think it's need to be added to Helm chart:

apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  labels:
    app.kubernetes.io/component: metrics
    app.kubernetes.io/instance: prometheus-adapter
    app.kubernetes.io/name: prometheus-adapter
  name: prometheus-adapter
  namespace: monitoring
spec:
  endpoints:
    - bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
      port: https
      scheme: https
      tlsConfig:
        insecureSkipVerify: true  # Need if certManager disabled
        serverName: prometheus-adapter
        ca:
          secret:
            key: ca.crt
            name: prometheus-adapter
            optional: false
  namespaceSelector:
    matchNames:
      - monitoring
  selector:
    matchLabels:
      app.kubernetes.io/component: metrics
      app.kubernetes.io/instance: prometheus-adapter
      app.kubernetes.io/name: prometheus-adapter

@stale stale bot removed the lifecycle/stale label Feb 12, 2024
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@steven-sheehy
Copy link
Member

Need to fix DCO

Signed-off-by: pauloferreira25 <[email protected]>
@PauloFerreira25
Copy link
Contributor Author

@steven-sheehy DONE

Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy changed the title [prometheus-adapter] KIA0601 [prometheus-adapter] Add a name to the Service object (KIA0601) Mar 18, 2024
@steven-sheehy steven-sheehy merged commit f1b9507 into prometheus-community:main Mar 18, 2024
4 checks passed
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants