-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-adapter] Add a name to the Service object (KIA0601) #3808
Conversation
b454288
to
eb2fdee
Compare
charts/prometheus-adapter/Chart.yaml
Outdated
@@ -1,6 +1,6 @@ | |||
apiVersion: v1 | |||
name: prometheus-adapter | |||
version: 4.5.0 | |||
version: 4.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to bump the version
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Bump. Example, i think it's need to be added to Helm chart:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Need to fix DCO |
Signed-off-by: pauloferreira25 <[email protected]>
@steven-sheehy DONE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…etheus-community#3808) Signed-off-by: pauloferreira25 <[email protected]>
What this PR does / why we need it
Fixes the KIA0601 error
Special notes for your reviewer
is just the name of the service
Checklist
[prometheus-couchdb-exporter]
)