Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-node-exporter] Remove toYaml function in extraManifests template #3799

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

shoce
Copy link
Contributor

@shoce shoce commented Sep 13, 2023

@gianrubio @zanhsieh @zeritti

Analogous to #3287 made for prometheus chart

What this PR does / why we need it

Trying to add an extra manifest

extraManifests:
  - |
      apiVersion: v1
      kind: ConfigMap
      metadata:
        namespace: prometheus-node-exporter
        name: configmap-prometheus-node-exporter-web-yaml
      data:
        prometheus-node-exporter-web.yaml: |
          # https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md
          basic_auth_users:
            admin: $aa$hashedpassword

getting helm install error:

Error: UPGRADE FAILED: YAML parse error on prometheus-node-exporter/templates/extra-manifests.yaml: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go value of type releaseutil.SimpleHead

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name

@zeritti
Copy link
Member

zeritti commented Sep 13, 2023

Thank you, @shoce, for your PR. Please, update the values file indicating the correct usage in the given example.

…emplate

Analogous to #3287 made for prometheus chart

Signed-off-by: Sho Ce <[email protected]>
@shoce
Copy link
Contributor Author

shoce commented Sep 13, 2023

Thank you, @shoce, for your PR. Please, update the values file indicating the correct usage in the given example

done

@zanhsieh zanhsieh merged commit d1c27b9 into prometheus-community:main Sep 14, 2023
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants