Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prometheus-fastly-exporter]: Add security context to fastly-exporter #3790

Merged
merged 4 commits into from
Sep 15, 2023
Merged

[prometheus-fastly-exporter]: Add security context to fastly-exporter #3790

merged 4 commits into from
Sep 15, 2023

Conversation

bkochendorfer
Copy link
Contributor

What this PR does / why we need it

Add ability to pass in SecurityContext and PodSecurityContext

Which issue this PR fixes

I don't think there is an issue.

Special notes for your reviewer

Tested in my cluster with the following:

prometheus-fastly-exporter:                                   
  securityContext:                 
    allowPrivilegeEscalation: false
    capabilities:                  
      drop: ["ALL"]                
                                   
  podSecurityContext:              
    seccompProfile:                
      type: RuntimeDefault         
    runAsNonRoot: true             
    runAsUser: 10001               
    runAsGroup: 10001

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@bkochendorfer
feat: Add security context to fastly-exporter
3d76303 
Add ability to pass in SecurityContext and PodSecurityContext

Signed-off-by: Brett Kochendorfer <[email protected]>
@bkochendorfer bkochendorfer force-pushed the fastly-exporter-security-context branch from 0fc41a8 to 3d76303 Compare September 12, 2023 15:19
@zanhsieh zanhsieh merged commit c48edfd into prometheus-community:main Sep 15, 2023
4 checks passed
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request Mar 20, 2024
@bkochendorfer @zanhsieh @Matiasmct
feat: Add security context to fastly-exporter (prometheus-community#3790
c406d24 
)

Add ability to pass in SecurityContext and PodSecurityContext

Signed-off-by: Brett Kochendorfer <[email protected]>
Co-authored-by: MH <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanhsieh zanhsieh zanhsieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkochendorfer @zanhsieh