[prometheus] Adding additionalPorts and servicePort #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morten Birkelund <[email protected]>
mortenbirkelund
requested review from
gianrubio,
naseemkullah,
Xtigyro,
zanhsieh and
zeritti
as code owners
Signed-off-by: MH <[email protected]>
zanhsieh
previously approved these changes
Sep 12, 2023
zeritti
requested changes
Sep 12, 2023
Co-authored-by: zeritti <[email protected]> Signed-off-by: Morten Birkelund <[email protected]>
zeritti
approved these changes
Sep 13, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…nity#3779) * Adding additionalPorts and servicePort Signed-off-by: Morten Birkelund <[email protected]> * Change version bump from patch to minor Co-authored-by: zeritti <[email protected]> Signed-off-by: Morten Birkelund <[email protected]> --------- Signed-off-by: Morten Birkelund <[email protected]> Signed-off-by: MH <[email protected]> Signed-off-by: Morten Birkelund <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: zeritti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Similar to #2163 for the kube-prometheus-stack, this PR will make it possible to add an oauth proxy as a sidecar container, and change the ingress to point to an additional port in your service, that then goes to your oauth proxy. Nice and simple way of adding oauth to Prometheus.
Which issue this PR fixes
No issues opened for this chart, but this have been solved for the kube-prometheus-stack chart, so why not also make it possible in the prometheus chart.
Special notes for your reviewer
I have checked the helm chart with my changed, and it seems to work fine, but let me know if any changes is required.
Checklist
[prometheus-couchdb-exporter])