[prometheus] Apply templating to remote_read & remote_write config #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garryod
requested review from
gianrubio,
naseemkullah,
Xtigyro,
zanhsieh and
zeritti
as code owners
garryod
force-pushed
the
main
branch
3 times, most recently
from
1358d39 to
bf81d3a
Compare
zanhsieh
requested changes
Sep 14, 2023
There was a problem hiding this comment.
@garryod
Thanks for the contribution. Since you bump to the major version, can you put some note that the users should know, such as upgrading, what are compatible, what are not compatible, or some reference links in README.md please?
Ah yes, will do! |
zeritti
requested changes
Sep 14, 2023
zeritti
changed the title
zeritti
requested changes
Sep 18, 2023
Signed-off-by: Garry O'Donnell <garry.o'[email protected]>
Signed-off-by: Garry O'Donnell <garry.o'[email protected]> Signed-off-by: Garry O'Donnell <[email protected]>
Signed-off-by: Garry O'Donnell <garry.o'[email protected]> Signed-off-by: Garry O'Donnell <[email protected]>
Co-authored-by: zeritti <[email protected]> Signed-off-by: Garry O'Donnell <[email protected]>
zanhsieh
approved these changes
Sep 19, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…rometheus-community#3777) * Apply templating to remote_read & remote_write config Signed-off-by: Garry O'Donnell <garry.o'[email protected]> * Add migration instructions for prometheus 25.0 Signed-off-by: Garry O'Donnell <garry.o'[email protected]> Signed-off-by: Garry O'Donnell <[email protected]> * Only template URLs Signed-off-by: Garry O'Donnell <garry.o'[email protected]> Signed-off-by: Garry O'Donnell <[email protected]> * Fix whitespace Co-authored-by: zeritti <[email protected]> Signed-off-by: Garry O'Donnell <[email protected]> --------- Signed-off-by: Garry O'Donnell <garry.o'[email protected]> Signed-off-by: Garry O'Donnell <[email protected]> Co-authored-by: zeritti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds template evaluation (via the
tplfunction) to theremoteRead&remoteWritefields in theConfigMap. This allows users of the chart to substitute values at templating time. This is especially useful if the services which a user wishes to write to are deployed as part of an adjacent sub-chart where their name includes the deployment name.Special notes for your reviewer
N/A
Checklist
[prometheus-couchdb-exporter])