Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] allow more flexible poddisruptionbudget config #3772

Merged
merged 5 commits into from
Sep 11, 2023
Merged

[prometheus] allow more flexible poddisruptionbudget config #3772

merged 5 commits into from
Sep 11, 2023

Conversation

starlightromero
Copy link
Contributor

@starlightromero starlightromero commented Sep 10, 2023

What this PR does / why we need it

Allow for more flexible podDisruptionBudget configuration in the prometheus Helm chart. This specifically allows the use of minAvailable on the server

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

@gianrubio

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

charts/prometheus/Chart.yaml Show resolved Hide resolved
charts/prometheus/templates/pdb.yaml Outdated Show resolved Hide resolved
charts/prometheus/templates/pdb.yaml Outdated Show resolved Hide resolved
charts/prometheus/values.yaml Outdated Show resolved Hide resolved
starlightromero and others added 3 commits September 10, 2023 15:25
Co-authored-by: zeritti <[email protected]>
Signed-off-by: Starlight Romero <[email protected]>
Co-authored-by: zeritti <[email protected]>
Signed-off-by: Starlight Romero <[email protected]>
Co-authored-by: zeritti <[email protected]>
Signed-off-by: Starlight Romero <[email protected]>
Copy link
Member

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @starlightromero.

@zeritti zeritti changed the title [prometheus]: allow more flexible poddisruptionbudget config [prometheus] allow more flexible poddisruptionbudget config Sep 11, 2023
@zeritti zeritti merged commit 1139547 into prometheus-community:main Sep 11, 2023
4 checks passed
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request Mar 20, 2024
…us-community#3772)

* fix(prometheus): allow more flexible poddisruptionbudget config

Signed-off-by: Starlight Romero <[email protected]>

* chore(prometheus): bump helm chart version

Signed-off-by: Starlight Romero <[email protected]>

* Update charts/prometheus/values.yaml

Co-authored-by: zeritti <[email protected]>
Signed-off-by: Starlight Romero <[email protected]>

* Update charts/prometheus/templates/pdb.yaml

Co-authored-by: zeritti <[email protected]>
Signed-off-by: Starlight Romero <[email protected]>

* Update charts/prometheus/templates/pdb.yaml

Co-authored-by: zeritti <[email protected]>
Signed-off-by: Starlight Romero <[email protected]>

---------

Signed-off-by: Starlight Romero <[email protected]>
Signed-off-by: Starlight Romero <[email protected]>
Co-authored-by: zeritti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants