[alertmanager] Add support for PVC retention policy in statefulset #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monotek
requested changes
Sep 27, 2023
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
3 times, most recently
from
f584f11 to
5fb7272
Compare
monotek
requested changes
Sep 28, 2023
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
from
405bc49 to
b62bc96
Compare
peterabarr
requested review from
desaintmartin and
Juanchimienti
as code owners
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
from
b62bc96 to
34d06cf
Compare
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
from
34d06cf to
77f80e2
Compare
monotek
requested changes
Sep 29, 2023
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
2 times, most recently
from
4614e50 to
a131c66
Compare
monotek
requested changes
Sep 29, 2023
monotek
approved these changes
Sep 29, 2023
monotek
requested changes
Sep 29, 2023
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
3 times, most recently
from
2374ff8 to
c64a568
Compare
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
2 times, most recently
from
25056fd to
0eb8690
Compare
monotek
previously approved these changes
Oct 2, 2023
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
from
00ead7b to
74f47fa
Compare
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
from
74f47fa to
6885f43
Compare
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
2 times, most recently
from
762c665 to
6e4287f
Compare
|
@monotek I had to make a change to fix the lint check failing & found a problem when helm templating in the statefulset.yaml file which I corrected if you could re-review, thanks |
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
10 times, most recently
from
79f6231 to
0e6661d
Compare
|
Thanks @peterabarr @monotek any updates on this we are waiting on this for our environment? |
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]> Change chart version Signed-off-by: peterabarr <[email protected]> Json changes Signed-off-by: peterabarr <[email protected]> Add to templates file Signed-off-by: peterabarr <[email protected]> Statefulset fix Signed-off-by: peterabarr <[email protected]> Fixes Signed-off-by: peterabarr <[email protected]>
peterabarr
force-pushed
the
feat/alertmanager-sts-autodeletepvc
branch
from
0e6661d to
5d25996
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
|
This issue is being automatically closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Kubernetes 1.27.0 enabled statefulset's persistent volume claim retention policy (beta) by means of which a PVC can either be retained or deleted on deleting and scaling down the statefulset, respectively.
To enable the auto delete feature in the chart, this PR adds fields
Values.persistentVolumeClaimRetentionPolicy.whenDeletedandValues.persistentVolumeClaimRetentionPolicy.whenScaled. Default value isretain(PVCs retained).The values schema file has been updated with recently added fields.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])