Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alertmanager] Add optional seperate ingress per replica #3689

Conversation

knutgoetz
Copy link
Contributor

What this PR does / why we need it

This pull request adds the ability to add a separate ingress for each Alertmanager replica. This allows for the replicas to be exposed and used as a highly available cluster by Prometheus instances outside the cluster.

Special notes for your reviewer

This feature was already implemented in the kube-prometheus-stack chart and has been adapted for this implementation. There are a few key differences to note:

  • This implementation does not support Ingress apiVersion < networking.k8s.io/v1
  • You cannot set a static nodePort for the services per replica. This is because statically assigning the port can lead to collisions when using more than one replica. If you are using only one replica, you can use the default service.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@monotek
Copy link
Member

monotek commented Aug 14, 2023

Can't you use a new k8s service which uses one of the pods?
So only one ingress would be needed.

@knutgoetz
Copy link
Contributor Author

Not sure, if i understand your suggestion correctly.
I need to send an alert from prometheus to every alertmanager pod to achieve high availability for the alertmanager cluster. It does not suffice to send the alert only to of the replicas, i.e. use simply one ingress+service which does the load balancing. That's why an extra service per replica is needed.

I could reach each of these services via one ingress with stuff like path based routing (different path per service, then deleting the path prefix) or with an ingress controller which supports mirroring the request to multiple services but this would need some additional work and relies on the specific ingress controller.
I thought that having one ingress per service is the simplest way to go.

@knutgoetz
Copy link
Contributor Author

Not sure if my previous comment clarified anything @monotek :)
I know this not the most urgent feature the community is waiting for - especially compared to the amount of code that is added. If you think this does not belong in the community chart, we will add the services/ingresses in our own setup and close this PR which is fine as well.

@knutgoetz knutgoetz force-pushed the feat/alertmanager/add-ingress-per-replica-setup branch 2 times, most recently from 9f5cc8a to d566739 Compare August 23, 2023 11:15
@knutgoetz knutgoetz force-pushed the feat/alertmanager/add-ingress-per-replica-setup branch from d566739 to dbc879b Compare August 28, 2023 12:05
monotek
monotek previously approved these changes Sep 27, 2023
@monotek monotek merged commit 304ff15 into prometheus-community:main Sep 27, 2023
4 checks passed
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Sep 28, 2023
…community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Sep 28, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Sep 28, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Sep 28, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Sep 29, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Sep 29, 2023
…community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Sep 29, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 2, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 2, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 2, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 2, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 2, 2023
…community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 2, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 3, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 3, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 4, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 5, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 6, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 6, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>

Change chart version

Signed-off-by: peterabarr <[email protected]>

Json changes

Signed-off-by: peterabarr <[email protected]>

Add to templates file

Signed-off-by: peterabarr <[email protected]>

Statefulset fix

Signed-off-by: peterabarr <[email protected]>

Fixes
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 6, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>

Change chart version

Signed-off-by: peterabarr <[email protected]>

Json changes

Signed-off-by: peterabarr <[email protected]>

Add to templates file

Signed-off-by: peterabarr <[email protected]>

Statefulset fix

Signed-off-by: peterabarr <[email protected]>

Fixes
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 6, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>

Change chart version

Signed-off-by: peterabarr <[email protected]>

Json changes

Signed-off-by: peterabarr <[email protected]>

Add to templates file

Signed-off-by: peterabarr <[email protected]>

Statefulset fix

Signed-off-by: peterabarr <[email protected]>

Fixes

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 6, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>

Change chart version

Signed-off-by: peterabarr <[email protected]>

Json changes

Signed-off-by: peterabarr <[email protected]>

Add to templates file

Signed-off-by: peterabarr <[email protected]>

Statefulset fix

Signed-off-by: peterabarr <[email protected]>

Fixes

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 9, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>

Change chart version

Signed-off-by: peterabarr <[email protected]>

Json changes

Signed-off-by: peterabarr <[email protected]>

Add to templates file

Signed-off-by: peterabarr <[email protected]>

Statefulset fix

Signed-off-by: peterabarr <[email protected]>

Fixes

Signed-off-by: peterabarr <[email protected]>
peterabarr pushed a commit to peterabarr/helm-charts that referenced this pull request Oct 11, 2023
…to the deployment (prometheus-community#3649)

* enable passing rabbitmq conection parameters

Signed-off-by: Daniel Gotlieb <[email protected]>

* Update chart version

Signed-off-by: dgotlieb <[email protected]>

* Update charts/prometheus-rabbitmq-exporter/Chart.yaml

Signed-off-by: André Bauer <[email protected]>

---------

Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: Daniel Gotlieb <[email protected]>
Co-authored-by: MH <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824)

* add-if-block-to-ingressClassName

Signed-off-by: jmnote <[email protected]>

* Chart Version bumped

Signed-off-by: jmnote <[email protected]>

---------

Signed-off-by: jmnote <[email protected]>
Co-authored-by: André Bauer <[email protected]>

[alertmanager] Add optional seperate ingress per replica (prometheus-community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Signed-off-by: peterabarr <[email protected]>

[alertmanager] Add support for PVC retention policy in statefulset

Fix

Fix PVC policy

Fix fmt

Signed-off-by: peterabarr <[email protected]>

Adjustments

Remove ternary

rm blank space

Signed-off-by: peterabarr <[email protected]>

Change chart version

Signed-off-by: peterabarr <[email protected]>

Json changes

Signed-off-by: peterabarr <[email protected]>

Add to templates file

Signed-off-by: peterabarr <[email protected]>

Statefulset fix

Signed-off-by: peterabarr <[email protected]>

Fixes

Signed-off-by: peterabarr <[email protected]>
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request Mar 20, 2024
…community#3689)

* [alertmanager] Add optional seperate ingress per replica

Signed-off-by: Knut Götz <[email protected]>

* chore(alertmanger): bump chart version

Signed-off-by: Knut Götz <[email protected]>

---------

Signed-off-by: Knut Götz <[email protected]>
Signed-off-by: André Bauer <[email protected]>
Co-authored-by: André Bauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants