[prometheus-rabbitmq-exporter] fix connection parameters not passing to the deployment #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Gotlieb <[email protected]>
Signed-off-by: dgotlieb <[email protected]>
Dgotlieb
requested review from
desaintmartin,
Juanchimienti and
monotek
as code owners
zeritti
changed the title
prometheus-rabbitmq-exporter fix connection parameters not passing to the deployment
monotek
requested changes
Aug 7, 2023
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Signed-off-by: André Bauer <[email protected]>
monotek
approved these changes
Sep 27, 2023
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Sep 28, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Sep 28, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Sep 28, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Sep 29, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Sep 29, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 2, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 2, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 2, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 2, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 2, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 3, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 3, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 4, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 5, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 6, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 6, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]> Change chart version Signed-off-by: peterabarr <[email protected]> Json changes Signed-off-by: peterabarr <[email protected]> Add to templates file Signed-off-by: peterabarr <[email protected]> Statefulset fix Signed-off-by: peterabarr <[email protected]> Fixes
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 6, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]> Change chart version Signed-off-by: peterabarr <[email protected]> Json changes Signed-off-by: peterabarr <[email protected]> Add to templates file Signed-off-by: peterabarr <[email protected]> Statefulset fix Signed-off-by: peterabarr <[email protected]> Fixes
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 6, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]> Change chart version Signed-off-by: peterabarr <[email protected]> Json changes Signed-off-by: peterabarr <[email protected]> Add to templates file Signed-off-by: peterabarr <[email protected]> Statefulset fix Signed-off-by: peterabarr <[email protected]> Fixes Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 6, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]> Change chart version Signed-off-by: peterabarr <[email protected]> Json changes Signed-off-by: peterabarr <[email protected]> Add to templates file Signed-off-by: peterabarr <[email protected]> Statefulset fix Signed-off-by: peterabarr <[email protected]> Fixes Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 9, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]> Change chart version Signed-off-by: peterabarr <[email protected]> Json changes Signed-off-by: peterabarr <[email protected]> Add to templates file Signed-off-by: peterabarr <[email protected]> Statefulset fix Signed-off-by: peterabarr <[email protected]> Fixes Signed-off-by: peterabarr <[email protected]>
peterabarr
pushed a commit
to peterabarr/helm-charts
that referenced
this pull request
Oct 11, 2023
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add if block to ingressClassName to use default ingressClass (prometheus-community#3824) * add-if-block-to-ingressClassName Signed-off-by: jmnote <[email protected]> * Chart Version bumped Signed-off-by: jmnote <[email protected]> --------- Signed-off-by: jmnote <[email protected]> Co-authored-by: André Bauer <[email protected]> [alertmanager] Add optional seperate ingress per replica (prometheus-community#3689) * [alertmanager] Add optional seperate ingress per replica Signed-off-by: Knut Götz <[email protected]> * chore(alertmanger): bump chart version Signed-off-by: Knut Götz <[email protected]> --------- Signed-off-by: Knut Götz <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: André Bauer <[email protected]> Signed-off-by: peterabarr <[email protected]> [alertmanager] Add support for PVC retention policy in statefulset Fix Fix PVC policy Fix fmt Signed-off-by: peterabarr <[email protected]> Adjustments Remove ternary rm blank space Signed-off-by: peterabarr <[email protected]> Change chart version Signed-off-by: peterabarr <[email protected]> Json changes Signed-off-by: peterabarr <[email protected]> Add to templates file Signed-off-by: peterabarr <[email protected]> Statefulset fix Signed-off-by: peterabarr <[email protected]> Fixes Signed-off-by: peterabarr <[email protected]>
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…to the deployment (prometheus-community#3649) * enable passing rabbitmq conection parameters Signed-off-by: Daniel Gotlieb <[email protected]> * Update chart version Signed-off-by: dgotlieb <[email protected]> * Update charts/prometheus-rabbitmq-exporter/Chart.yaml Signed-off-by: André Bauer <[email protected]> --------- Signed-off-by: Daniel Gotlieb <[email protected]> Signed-off-by: dgotlieb <[email protected]> Signed-off-by: André Bauer <[email protected]> Co-authored-by: Daniel Gotlieb <[email protected]> Co-authored-by: MH <[email protected]> Co-authored-by: André Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The parameters of
rabbitmq.user,rabbitmq.passwordandrabbitmq.urldidn't pass to the deployment's env variables,which cause getting 401 (as it used the defaults)
Which issue this PR fixes
The chart never worked before while passing the values from the
values.yamlfile.In a roundabout way it fixed this issue
Checklist
[prometheus-couchdb-exporter])