Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-elasticsearch-exporter] Re-introduce pod security context toggle #3646

Conversation

zeritti
Copy link
Member

@zeritti zeritti commented Jul 27, 2023

What this PR does / why we need it

This PR re-introduces a toggle on the pod security context (enabled by default) making thus life easier for OpenShift users.

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@zeritti zeritti marked this pull request as ready for review July 27, 2023 12:40
@zeritti zeritti requested a review from desaintmartin as a code owner July 27, 2023 12:40
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

zanhsieh
zanhsieh previously approved these changes Oct 15, 2023
@stale stale bot removed the lifecycle/stale label Oct 15, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot removed the lifecycle/stale label Dec 19, 2023
zanhsieh
zanhsieh previously approved these changes Dec 19, 2023
@zanhsieh
Copy link
Contributor

@monotek
Can you help with PR please?

@monotek
Copy link
Member

monotek commented Jan 8, 2024

why is this needed?
you could just comment out "podSecurityContext" and achive the same, or not?

@zeritti
Copy link
Member Author

zeritti commented Jan 8, 2024

why is this needed? you could just comment out "podSecurityContext" and achive the same, or not?

Although the field can be set to null, using a toggle is preferred. Such a toggle had previously been present in the chart but unfortunately removed.

@monotek
Copy link
Member

monotek commented Jan 8, 2024

using a toggle is preferred

by whom?
i don't see the benefit.

i guess if it was removed before we might end up in a new pr by somebody else which removes it again.

@zeritti zeritti closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-elasticsearch-exporter] podSecurityContext togglable for openshift compatibility
3 participants