-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kube-prometheus-stack] Updating value name for nodeExporter MacOS dashboard #3385
[kube-prometheus-stack] Updating value name for nodeExporter MacOS dashboard #3385
Conversation
371bc4d
to
dc61859
Compare
Signed-off-by: Piotr Kowalczyk <[email protected]>
dc61859
to
5a003ed
Compare
Signed-off-by: Piotr Kowalczyk <[email protected]>
Signed-off-by: Piotr Kowalczyk <[email protected]>
5a003ed
to
653b5aa
Compare
This looks more like a breaking change than a patch. What value does it bring exactly? |
It allows one to have just a dashboard for node-exporter, if one doesn't use MacOS node-exporters, so generally for as clean installation as possible. I basically wanted to disable dashboards that I will not use - this is one of them. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Opened new pull request from new branch #3778 |
What this PR does / why we need it
This PR adds new value - .Values.nodeExporterMacOS.enabled.
It's used for controlling creation of Node Exporter Mac OS Grafana dashboard.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)n/a
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter]
)