Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Updating value name for nodeExporter MacOS dashboard #3385

Conversation

nicon89
Copy link
Contributor

@nicon89 nicon89 commented May 16, 2023

What this PR does / why we need it

This PR adds new value - .Values.nodeExporterMacOS.enabled.
It's used for controlling creation of Node Exporter Mac OS Grafana dashboard.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
n/a

Special notes for your reviewer

Checklist

  • [ X ] DCO signed
  • [ X ] Chart Version bumped
  • [ X ] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@nicon89 nicon89 force-pushed the add_nodeexporter_macos_enabled_flag branch from dc61859 to 5a003ed Compare May 16, 2023 12:28
nicon89 added 2 commits May 16, 2023 14:28
Signed-off-by: Piotr Kowalczyk <[email protected]>
Signed-off-by: Piotr Kowalczyk <[email protected]>
@nicon89 nicon89 force-pushed the add_nodeexporter_macos_enabled_flag branch from 5a003ed to 653b5aa Compare May 16, 2023 12:29
@QuentinBisson
Copy link
Member

This looks more like a breaking change than a patch. What value does it bring exactly?

@nicon89
Copy link
Contributor Author

nicon89 commented May 16, 2023

It allows one to have just a dashboard for node-exporter, if one doesn't use MacOS node-exporters, so generally for as clean installation as possible. I basically wanted to disable dashboards that I will not use - this is one of them.

@stale
Copy link

stale bot commented Jun 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale
Copy link

stale bot commented Aug 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Aug 7, 2023
@stale stale bot removed the lifecycle/stale label Sep 2, 2023
@nicon89 nicon89 closed this Sep 11, 2023
@nicon89 nicon89 deleted the add_nodeexporter_macos_enabled_flag branch September 11, 2023 18:34
@nicon89
Copy link
Contributor Author

nicon89 commented Sep 11, 2023

Opened new pull request from new branch #3778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants