Skip to content

Commit

Permalink
[kube-prometheus-stack] Update ambiguous doc comment for selfMonitor (#…
Browse files Browse the repository at this point in the history
…4327)

* Update values.yaml

Signed-off-by: denist11 <[email protected]>

* Bump version of kube-prometheus-stack

Signed-off-by: denist11 <[email protected]>

* Move specific doc comments to their corresponding fields

Signed-off-by: denist11 <[email protected]>

---------

Signed-off-by: denist11 <[email protected]>
  • Loading branch information
denist11 authored Mar 4, 2024
1 parent b7592f7 commit f68217d
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 10 deletions.
2 changes: 1 addition & 1 deletion charts/kube-prometheus-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ name: kube-prometheus-stack
sources:
- https://github.com/prometheus-community/helm-charts
- https://github.com/prometheus-operator/kube-prometheus
version: 56.20.0
version: 56.20.1
appVersion: v0.71.2
kubeVersion: ">=1.19.0-0"
home: https://github.com/prometheus-operator/kube-prometheus
Expand Down
30 changes: 21 additions & 9 deletions charts/kube-prometheus-stack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -557,13 +557,16 @@ alertmanager:
##
type: ClusterIP

## If true, create a serviceMonitor for alertmanager
## Configuration for creating a ServiceMonitor for AlertManager
##
serviceMonitor:
## If true, a ServiceMonitor will be created for the AlertManager service.
##
selfMonitor: true

## Scrape interval. If not set, the Prometheus default scrape interval is used.
##
interval: ""
selfMonitor: true

## Additional labels
##
Expand Down Expand Up @@ -2571,10 +2574,10 @@ prometheusOperator:
## Decrease log verbosity to errors only
# logLevel: error

## If true, the operator will create and maintain a service for scraping kubelets
## ref: https://github.com/prometheus-operator/prometheus-operator/blob/main/helm/prometheus-operator/README.md
##
kubeletService:
## If true, the operator will create and maintain a service for scraping kubelets
## ref: https://github.com/prometheus-operator/prometheus-operator/blob/main/helm/prometheus-operator/README.md
##
enabled: true
namespace: kube-system
## Use '{{ template "kube-prometheus-stack.fullname" . }}-kubelet' by default
Expand All @@ -2583,6 +2586,10 @@ prometheusOperator:
## Create a servicemonitor for the operator
##
serviceMonitor:
## If true, create a serviceMonitor for prometheus operator
##
selfMonitor: true

## Labels for ServiceMonitor
additionalLabels: {}

Expand Down Expand Up @@ -2612,7 +2619,6 @@ prometheusOperator:

## Scrape timeout. If not set, the Prometheus default scrape timeout is used.
scrapeTimeout: ""
selfMonitor: true

## Metric relabel configs to apply to samples before ingestion.
##
Expand Down Expand Up @@ -3210,10 +3216,13 @@ prometheus:
volumes: []

serviceMonitor:
## If true, create a serviceMonitor for prometheus
##
selfMonitor: true

## Scrape interval. If not set, the Prometheus default scrape interval is used.
##
interval: ""
selfMonitor: true

## Additional labels
##
Expand Down Expand Up @@ -4236,13 +4245,16 @@ thanosRuler:
##
type: ClusterIP

## If true, create a serviceMonitor for thanosRuler
## Configuration for creating a ServiceMonitor for the ThanosRuler service
##
serviceMonitor:
## If true, create a serviceMonitor for thanosRuler
##
selfMonitor: true

## Scrape interval. If not set, the Prometheus default scrape interval is used.
##
interval: ""
selfMonitor: true

## Additional labels
##
Expand Down

0 comments on commit f68217d

Please sign in to comment.