[prometheus-snmp-exporter] configmap-reload change image to quay.io (#…

…4304) * Change SNMP exporter configmap-reload image to quay.io Signed-off-by: Mohammadreza Tavakoli <[email protected]> Signed-off-by: mrt <[email protected]> * bump chart version to 3.0.1 Signed-off-by: mrt <[email protected]> * Change chart version to 4.0.0 Signed-off-by: mrt <[email protected]> * Add version 4.0.0 notes to readme file of snmp exporter Signed-off-by: mrt <[email protected]> * Change Config Reloader Args in Deployment & Deamonset Signed-off-by: mrt <[email protected]> --------- Signed-off-by: Mohammadreza Tavakoli <[email protected]> Signed-off-by: mrt <[email protected]> Signed-off-by: Faust <[email protected]> Signed-off-by: Tom Walker <[email protected]> Co-authored-by: mrt <[email protected]> Co-authored-by: Tom Walker <[email protected]>
prometheus-community · Feb 29, 2024 · d452d20 · d452d20
1 parent e6997a1
commit d452d20
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/charts/prometheus-snmp-exporter/Chart.yaml b/charts/prometheus-snmp-exporter/Chart.yaml
@@ -1,7 +1,7 @@
 apiVersion: v1
 description: Prometheus SNMP Exporter
 name: prometheus-snmp-exporter
-version: 3.1.1
+version: 4.0.0
 appVersion: v0.24.1
 home: https://github.com/prometheus/snmp_exporter
 sources:

diff --git a/charts/prometheus-snmp-exporter/README.md b/charts/prometheus-snmp-exporter/README.md
@@ -86,6 +86,10 @@ This version changes the `serviceMonitor.namespace` value from `monitoring` to t
 This version upgrades snmp-exporter version to 0.24.1, which introduces breaking change to configuration format.
 See [Module and Auth Split Migration](https://github.com/prometheus/snmp_exporter/blob/main/auth-split-migration.md) for more details.
 
+### To 4.0.0
+
+This version contain major changes & The [configmap-reload](https://github.com/jimmidyson/configmap-reload) container was replaced by the [prometheus-config-reloader](https://github.com/prometheus-operator/prometheus-operator/tree/main/cmd/prometheus-config-reloader).
+
 ## Configuration
 
 See [Customizing the Chart Before Installing](https://helm.sh/docs/intro/using_helm/#customizing-the-chart-before-installing). To see all configurable options with detailed comments, visit the chart's [values.yaml](./values.yaml), or run these configuration commands:

diff --git a/charts/prometheus-snmp-exporter/templates/daemonset.yaml b/charts/prometheus-snmp-exporter/templates/daemonset.yaml
@@ -80,8 +80,8 @@ spec:
           image: "{{ .Values.configmapReload.image.repository }}:{{ .Values.configmapReload.image.tag }}"
           imagePullPolicy: "{{ .Values.configmapReload.image.pullPolicy }}"
           args:
-            - --volume-dir=/etc/config
-            - --webhook-url=http://localhost:{{ .Values.service.port }}/-/reload
+            - --watched-dir=/etc/config
+            - --reload-url=http://localhost:{{ .Values.service.port }}/-/reload
           resources:
 {{ toYaml .Values.configmapReload.resources | indent 12 }}
           volumeMounts:

diff --git a/charts/prometheus-snmp-exporter/templates/deployment.yaml b/charts/prometheus-snmp-exporter/templates/deployment.yaml
@@ -87,8 +87,8 @@ spec:
           image: "{{ .Values.configmapReload.image.repository }}:{{ .Values.configmapReload.image.tag }}"
           imagePullPolicy: "{{ .Values.configmapReload.image.pullPolicy }}"
           args:
-            - --volume-dir=/etc/config
-            - --webhook-url=http://localhost:{{ .Values.service.port }}/-/reload
+            - --watched-dir=/etc/config
+            - --reload-url=http://localhost:{{ .Values.service.port }}/-/reload
           resources:
 {{ toYaml .Values.configmapReload.resources | indent 12 }}
           volumeMounts:

diff --git a/charts/prometheus-snmp-exporter/values.yaml b/charts/prometheus-snmp-exporter/values.yaml
@@ -139,8 +139,8 @@ configmapReload:
   ## configmap-reload container image
   ##
   image:
-    repository: jimmidyson/configmap-reload
-    tag: v0.5.0
+    repository: quay.io/prometheus-operator/prometheus-config-reloader
+    tag: v0.71.2
     pullPolicy: IfNotPresent
 
   ## configmap-reload resource requests and limits