Skip to content

Commit

Permalink
added with statement for mount type so it does not have to be set
Browse files Browse the repository at this point in the history
Signed-off-by: Nicole <[email protected]>
  • Loading branch information
nfrazier08 committed Jan 31, 2024
1 parent 1dafb68 commit 460e551
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 3 additions & 1 deletion charts/prometheus-node-exporter/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,9 @@ spec:
{{- with $mount.mountPropagation }}
mountPropagation: {{ . }}
{{- end }}
type: {{ $mount.type}}
{{- with $mount.type }}
type: {{ . }}
{{- end }}
{{- end }}
{{- range $_, $mount := .Values.sidecarVolumeMount }}
- name: {{ $mount.name }}
Expand Down
5 changes: 3 additions & 2 deletions charts/prometheus-node-exporter/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -388,14 +388,15 @@ extraArgs: []

## Additional mounts from the host to node-exporter container
##
extraHostVolumeMounts: []
#extraHostVolumeMounts: []

Check failure on line 391 in charts/prometheus-node-exporter/values.yaml

View workflow job for this annotation

GitHub Actions / lint-test

391:2 [comments] missing starting space in comment
# - name: <mountName>
# hostPath: <hostPath>
# mountPath: <mountPath>
# readOnly: true|false
# mountPropagation: None|HostToContainer|Bidirectional
# https://kubernetes.io/docs/concepts/storage/volumes/#hostpath-volume-types
# type: "" (Default)|DirectoryOrCreate|Directory|FileOrCreate|File|Socket|CharDevice|BlockDevice
# mountPropagation: None|HostToContainer|Bidirectional


## Additional configmaps to be mounted.
##
Expand Down

0 comments on commit 460e551

Please sign in to comment.