Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests for cluster health #811

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Refactor tests for cluster health #811

merged 2 commits into from
Dec 2, 2023

Conversation

sysadmind
Copy link
Contributor

  • Remove up, totalScrapes, and jsonParseFailures metrics. They are not useful.
  • Move fixtures to individual files
  • Base tests on the metric output for better testing the expected output instead of the internals.

@sysadmind
Refactor tests for cluster health
acddc58 
- Remove up, totalScrapes, and jsonParseFailures metrics. They are not useful.
- Move fixtures to individual files
- Base tests on the metric output for better testing the expected output instead of the internals.

Signed-off-by: Joe Adams <[email protected]>
@sysadmind sysadmind added this to the Test Cleanup milestone Nov 15, 2023
@sysadmind sysadmind requested a review from SuperQ November 15, 2023 02:31
SuperQ
SuperQ reviewed Dec 2, 2023
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Collect() doesn't return a 500 error on failure, we probably want to keep the up metric.

SuperQ
SuperQ approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, this is a subsystem up. That's not useful.

@SuperQ SuperQ merged commit 8393bfc into prometheus-community:master Dec 2, 2023
2 checks passed
@sysadmind sysadmind deleted the refactor-tests-cluster-health branch December 21, 2023 19:17
@sysadmind sysadmind mentioned this pull request Feb 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Test Cleanup
Development

Successfully merging this pull request may close these issues.
2 participants
@sysadmind @SuperQ