Fixes missing labels from the generated metrics and adds a test for it #115

prateeknayak · 2025-01-02T00:02:12Z

We have been using avalanche to test out remote write capability in our distributed metrics architecture, we noticed that avalanche wasn't adding any labels let alone the --const-labels to the metrics. The solution in the PR should hopefully fix it.
Following are the changes in the PR

Added a test to check for labels in the generated metrics
Updated line 516-517 in metrics/serve.go to fix the issue

Adding in the DCO Licensing

…us-community#2)

avalanche's k8s deployment yaml file

…ity#4) Create our own registry so we don't include any other metrics that Prometheus client_golang adds by default.

Add option to send via remote_write API; update to Go 1.12.1

Closes prometheus-community#9

…us-community#8) * Use go modules and implement remote write samples count flag. * concurent send * added continious profiling. * fix dockerfile * fix remotePprof wait * fix the series update lock race * total samples count * nits * update ts for each request * improve the cache for docker build * nits

…ite API (prometheus-community#11) * Mention that Avalanche supports load testing via Prometheus remote_write API * README.md: move Thanos to remote_write section

* Fix time interval handling * Change to NewTicker from Ticker Keep ticker reference to avoid "leaking" * Update write.go

…nant-id Allow the tenant ID to be specified for remote_write [Rebase]

Co-authored-by: Andre Branchizio <[email protected]>

Co-authored-by: Hammond95 <[email protected]>

Happy to help in maintaining!

…nity#83) * Update common Prometheus files * Added format command. --------- Co-authored-by: bwplotka <[email protected]>

…theus-community#95) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.3 to 1.20.4. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.3...v1.20.4) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ommunity#94) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.57.0 to 0.60.0. - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md) - [Commits](prometheus/common@v0.57.0...v0.60.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… well; improved flag docs and tests for complex type series calculation. (prometheus-community#93)

…ibutions. (prometheus-community#97) Initially added in bwplotka/prombenchy#12, but it might belong here more.

@jmichalek132

…heus-community#99) See related discussion: prometheus-community#97 (comment) > I think we should move this default to zero. Essentially I don't see real case of changing metric names in any application. Metric names are generally stable AFAIK, do you know any cases where that's not true? Are they often? cc @jmichalek132

…#100)

Prior to this commit, unbounded number of write would have been trigged from avalanche based on number of samples and batch size. Adding a new flag to limit the concurrency will be useful to simulate prometheus remote write sharding.

…y#104)

…munity#111) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…theus-community#107) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.4 to 1.20.5. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.4...v1.20.5) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ommunity#105) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.60.0 to 0.60.1. - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md) - [Commits](prometheus/common@v0.60.0...v0.60.1) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-patch ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Refactor remote write flags into init method * Fix lint * Implement suggestions * Address comments ---------

Signed-off-by: Prateek <[email protected]>

limscoder and others added 30 commits August 20, 2018 09:16

Initial commit

bb84714

Added some codez.

f1c1be8

Adding in the DCO Licensing

78bc472

Merge pull request prometheus-community#1 from Fresh-Tracks/Licensing

d91e90f

Adding in the DCO Licensing

containerized

46de37a

containerized

4ef7b32

Update README.md

95e3ccb

avalanche's k8s deployment yaml file

bfe0db2

Use multi-stage builds to reduce size of final docker image (promethe…

00d5dcd

…us-community#2)

added avalanche's k8s deployment yaml file in k8s folder

a79cac9

updated latest tag in avalanche's image name in deployment spec

57b7ca4

Merge pull request prometheus-community#3 from ravishankarsrrav/patch-1

300277b

avalanche's k8s deployment yaml file

Serve just avalanche metrics, not Go metrics, etc. (prometheus-commun…

538f04e

…ity#4) Create our own registry so we don't include any other metrics that Prometheus client_golang adds by default.

Update vendor packages

a8d0710

Update to Go 1.12.1

1f2a4c9

Update paths to open-fresh

aed659c

Split functionality into RunMetrics() and ServeMetrics()

240afd9

Send metrics via remote_write API

83f13a8

Merge pull request prometheus-community#5 from bboreham/remote-write

d66d6cc

Add option to send via remote_write API; update to Go 1.12.1

Add automated build via CircleCI

bf3cb75

Closes prometheus-community#9

Mention that Avalanche supports load testing via Prometheus remote_wr…

808a596

…ite API (prometheus-community#11) * Mention that Avalanche supports load testing via Prometheus remote_write API * README.md: move Thanos to remote_write section

Fix time interval handling (prometheus-community#12)

19b7eb4

* Fix time interval handling * Change to NewTicker from Ticker Keep ticker reference to avoid "leaking" * Update write.go

Allow the tenant ID to be specified for remote_write

377157f

Merge pull request prometheus-community#14 from forestsword/update-te…

d9e4dca

…nant-id Allow the tenant ID to be specified for remote_write [Rebase]

Upgrade golang to 1.15

48ea8e1

Upgrade dependencies

85e9337

Add constant label argument (prometheus-community#17)

90fe7c4

Co-authored-by: Andre Branchizio <[email protected]>

feat: Add healthcheck (prometheus-community#15)

c24a4a5

add options to insecure tls. (prometheus-community#26)

f41648b

Co-authored-by: Hammond95 <[email protected]>

bwplotka and others added 20 commits October 1, 2024 09:17

Propose bwplotka as the avalanche maintainer (prometheus-community#91)

62c6e49

Happy to help in maintaining!

Update install command (prometheus-community#44)

9a62e27

Synchronize common files from prometheus/prometheus (prometheus-commu…

310a4ca

…nity#83) * Update common Prometheus files * Added format command. --------- Co-authored-by: bwplotka <[email protected]>

feat: Made sure summaries actually give output quantile objectives as…

7f764b9

… well; improved flag docs and tests for complex type series calculation. (prometheus-community#93)

Update common Prometheus files (prometheus-community#96)

6fe3f50

Added mtypes CLI for generating realistic avalanche metric type distr…

dd2bbc7

…ibutions. (prometheus-community#97) Initially added in bwplotka/prombenchy#12, but it might belong here more.

Update common Prometheus files (prometheus-community#98)

29ab7eb

Added validation and enum for operational mode. (prometheus-community…

a38456b

…#100)

Cut 0.6.0 (prometheus-community#101)

9968850

Log remote write errors as they happen (prometheus-community#102)

4a8209e

Deprecate pprof feature; Fix request sending bug (prometheus-communit…

8593639

…y#104)

Update common Prometheus files (prometheus-community#109)

9996385

Refactor remote write flags into init method (prometheus-community#103)

36db889

* Refactor remote write flags into init method * Fix lint * Implement suggestions * Address comments ---------

prateeknayak force-pushed the fix-missing-labels branch from 28b96a5 to dc5e076 Compare January 2, 2025 00:04

prateeknayak changed the title ~~Fixes missing labesl from the generated metrics and adds a test for it~~ Fixes missing labels from the generated metrics and adds a test for it Jan 2, 2025

prateeknayak force-pushed the fix-missing-labels branch 2 times, most recently from 73ff744 to ee3865e Compare January 2, 2025 00:22

prateek added 3 commits January 2, 2025 11:25

Fixes missing labesl from the generated metrics and adds a test for it

2a0f27f

Signed-off-by: Prateek <[email protected]>

Adds final new line

8b43c22

Signed-off-by: Prateek <[email protected]>

Fixes formating issue

83ef83c

Signed-off-by: Prateek <[email protected]>

prateeknayak closed this Jan 2, 2025

prateeknayak force-pushed the fix-missing-labels branch from ee3865e to 83ef83c Compare January 2, 2025 00:26

prateeknayak deleted the fix-missing-labels branch January 2, 2025 00:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes missing labels from the generated metrics and adds a test for it #115

Fixes missing labels from the generated metrics and adds a test for it #115

prateeknayak commented Jan 2, 2025

Fixes missing labels from the generated metrics and adds a test for it #115

Fixes missing labels from the generated metrics and adds a test for it #115

Conversation

prateeknayak commented Jan 2, 2025