-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move naive assertion to common role #443
refactor: move naive assertion to common role #443
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please go ahead with applying the change across all the roles
525bdbf
to
bbeee20
Compare
Done. It's ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to remove the naive assertion task here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. It's removed.
I wonder if this assert should be added to the cadvisor role too. |
Signed-off-by: Jack <[email protected]>
bbeee20
to
2ec62b3
Compare
I should list cadvisor in the description. It is not added intentionally. Because it is not in standard format. $ docker run --rm -it gcr.io/cadvisor/cadvisor --help | grep -E 'listen|port'
Only report docker containers in addition to root stats
-listen_ip string
IP to listen on, defaults to all IPs
-port int
port to listen (default 8080)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If this proposal is accepted, I'll update all other roles