Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move naive assertion to common role #443

Conversation

zhan9san
Copy link
Contributor

If this proposal is accepted, I'll update all other roles

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please go ahead with applying the change across all the roles

@zhan9san zhan9san force-pushed the feature/move-naive-assertion-to-common-role branch from 525bdbf to bbeee20 Compare October 29, 2024 15:35
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Oct 29, 2024
@zhan9san
Copy link
Contributor Author

Done. It's ready for review

@SuperQ SuperQ requested a review from gardar October 29, 2024 16:34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove the naive assertion task here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. It's removed.

@gardar
Copy link
Member

gardar commented Oct 29, 2024

I wonder if this assert should be added to the cadvisor role too.

@zhan9san zhan9san force-pushed the feature/move-naive-assertion-to-common-role branch from bbeee20 to 2ec62b3 Compare October 30, 2024 01:53
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Oct 30, 2024
@zhan9san
Copy link
Contributor Author

I wonder if this assert should be added to the cadvisor role too.

I should list cadvisor in the description.

It is not added intentionally. Because it is not in standard format.

$ docker run --rm -it gcr.io/cadvisor/cadvisor --help | grep -E 'listen|port'
    	Only report docker containers in addition to root stats
  -listen_ip string
    	IP to listen on, defaults to all IPs
  -port int
    	port to listen (default 8080)

node_exporter and others is in this format, --web.listen-address=:9100.

@zhan9san zhan9san mentioned this pull request Oct 31, 2024
@SuperQ SuperQ requested a review from gardar October 31, 2024 11:33
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gardar gardar changed the title feat: move naive assertion to common role refactor: move naive assertion to common role Oct 31, 2024
@github-actions github-actions bot added trivial and removed enhancement New feature or request labels Oct 31, 2024
@gardar gardar merged commit 007c8a4 into prometheus-community:main Oct 31, 2024
676 checks passed
@zhan9san zhan9san deleted the feature/move-naive-assertion-to-common-role branch November 1, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment