fix: make sure antsibull-changelog doesn't offend ansible-lint #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardar
force-pushed
the
fix-changelog-breakage
branch
from
2835a8a to
370e462
Compare
|
Looks like the upstream change has been approved. Let's give it a bit to see if they merge. |
Yeah sure, I've added another PR which fixes the sorting of the changelog entries as well: ansible-community/antsibull-changelog#165 |
gardar
force-pushed
the
fix-changelog-breakage
branch
from
370e462 to
a0f367d
Compare
Signed-off-by: gardar <[email protected]>
Signed-off-by: gardar <[email protected]>
gardar
force-pushed
the
fix-changelog-breakage
branch
from
a0f367d to
81fb097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally figured out why the format of
changelog.yamlgets messed up from time to time.I thought
antsichautwas the culpit but it turns out thatantsibull-changelogwas responsible.The workflow first passes the changelog to
antsibull-changelogand then toantsichaut.antsibull-changelogrewrites the changelog even if there is no new change butantsichautskips processing it when there are no new changes.And apparently the yaml that
antsibull-changelogwas putting out was not compatible withansible-lint.I've proposed fixes over at ansible-community/antsibull-changelog#160 and ansible-community/antsibull-changelog#165