-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve apt facts install #354
Conversation
64d1dca
to
e3c3418
Compare
e3c3418
to
3206a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to switch the task over to apt
as the package
module is actually just a proxy for apt or whatever package manager is present.
With that being said, the way the task is configured right now it actually never runs on any non apt systems.
I think we should make sure the task also installs the required dependencies for other distros, even though we don't run tests against them. it looks like suse requires python3-rpm and gentoo needs qlist.
Except we do need to switch to |
That is true but it simply passes the parameters down to the underlying module that it's proxy-ing. |
Reduce the number of packages installed by the apt package facts preflight by using the apt module and disabling recommends packages. Signed-off-by: SuperQ <[email protected]>
3206a40
to
37b129f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to only pass the install_recommends
parameter if ansible_pkg_mgr
is apt
else omit it to avoid future issues.
Docs Build 📝This PR is closed and any previously published docsite has been unpublished. |
Reduce the number of packages installed by the apt package facts preflight by using the apt module and disabling recommends packages.