Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Add ability to disable exporter metrics itself #324

Merged

Conversation

ritmas
Copy link
Contributor

@ritmas ritmas commented Mar 24, 2024

Add ability to disable exporter metrics itself which is a long-lasting feature of node_exporter (source code):

$ docker run -it quay.io/prometheus/node-exporter:latest --help | grep 'web.disable' -A1
      --[no-]web.disable-exporter-metrics  
                                 Exclude metrics about the exporter itself (promhttp_*, process_*, go_*).

@github-actions github-actions bot added enhancement New feature or request roles/node_exporter labels Mar 24, 2024
Copy link
Contributor

github-actions bot commented Mar 24, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@ritmas
Copy link
Contributor Author

ritmas commented Mar 28, 2024

@SuperQ when this PR can be merged? Is something missing?

@SuperQ
Copy link
Contributor

SuperQ commented Apr 3, 2024

Sorry, I'm working on an issue with the changelog generator. I'm trying to avoid corrupting the changelog more.

@gardar gardar force-pushed the feature/disable-exporter-metrics branch from 3872f7a to dae9cd6 Compare April 9, 2024 12:31
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Apr 9, 2024
@gardar gardar merged commit 4cd2a5a into prometheus-community:main Apr 9, 2024
43 checks passed
@ritmas ritmas deleted the feature/disable-exporter-metrics branch April 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants