feat: pushgateway extra parameters #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weakcamel
changed the title
weakcamel
force-pushed
the
weakcamel/pushgateway_extra_cli_params
branch
from
a0b982e to
55d9898
Compare
github-actions
bot
added
enhancement
weakcamel
force-pushed
the
weakcamel/pushgateway_extra_cli_params
branch
from
55d9898 to
dceb0ca
Compare
github-actions
bot
added
enhancement
weakcamel
force-pushed
the
weakcamel/pushgateway_extra_cli_params
branch
from
dceb0ca to
24b74c8
Compare
github-actions
bot
added
enhancement
weakcamel
force-pushed
the
weakcamel/pushgateway_extra_cli_params
branch
from
24b74c8 to
b63a01a
Compare
github-actions
bot
added
enhancement
gardar
requested changes
Apr 9, 2024
github-actions
bot
added
enhancement
Docs Build 📝This PR is closed and any previously published docsite has been unpublished. |
Sure thing, done. PTAL |
gardar
reviewed
Apr 10, 2024
weakcamel
force-pushed
the
weakcamel/pushgateway_extra_cli_params
branch
from
3731594 to
57572f9
Compare
github-actions
bot
added
enhancement
Silly me! of course, done. |
SuperQ
requested changes
Apr 10, 2024
|
Can this be merged? |
github-actions
bot
added
enhancement
weakcamel
force-pushed
the
weakcamel/pushgateway_extra_cli_params
branch
from
8c7264a to
cfa28dc
Compare
github-actions
bot
added
enhancement
weakcamel
force-pushed
the
weakcamel/pushgateway_extra_cli_params
branch
from
cfa28dc to
7e453fe
Compare
github-actions
bot
added
enhancement
|
Changes made as requested (sorry for losing this out of my radar for so long). Unfortunately there are currently some issues with the CI: Rebased the changes and trying again. |
Allow passing in additional parameters for the pushgateway binary * pushgateway_web_external_url - useful when running behind a reverse proxy * pushgateway_cli_extra_flags - additional extra flags for flexibility Signed-off-by: Waldek Maleska <[email protected]>
Signed-off-by: Waldek Maleska <[email protected]>
Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Waldek Maleska <[email protected]>
weakcamel
force-pushed
the
weakcamel/pushgateway_extra_cli_params
branch
from
7e453fe to
b1bcedf
Compare
github-actions
bot
added
enhancement
|
No traction so closing this PR. |
|
@weakcamel sorry about the radio silence, was doing some major overhaul of the roles and tests in the background, which have now been merged #395 and #425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing in additional parameters for the pushgateway binary
pushgateway_web_external_url- useful when running behind a reverse proxypushgateway_cli_extra_flags- additional extra flags for flexibilityResolves #288