Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Add time_intervals to AlertManager #251

Merged
merged 8 commits into from
Dec 12, 2023
Merged

enhancement: Add time_intervals to AlertManager #251

merged 8 commits into from
Dec 12, 2023

Conversation

rezizter
Copy link
Contributor

No description provided.

@github-actions github-actions bot added enhancement New feature or request roles/alertmanager labels Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@rezizter rezizter force-pushed the alertmanager_time_intervals branch from fa82fc0 to 85acf87 Compare November 29, 2023 21:00
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 29, 2023
@rezizter
Copy link
Contributor Author

Add this feature: #235

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 29, 2023
@rezizter rezizter force-pushed the alertmanager_time_intervals branch from a641bb2 to be2bca1 Compare November 29, 2023 21:21
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 29, 2023
@gardar
Copy link
Member

gardar commented Nov 29, 2023 •
edited
Loading

Thanks! Can you add it to the molecule test as well?
And also a version check, the option was introduced in version 0.22.0 prometheus/alertmanager#2393

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 30, 2023
@rezizter rezizter force-pushed the alertmanager_time_intervals branch from 490a19a to f02932d Compare November 30, 2023 06:19
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 30, 2023
@rezizter
Copy link
Contributor Author

Thanks! Can you add it to the molecule test as well? And also a version check, the option was introduced in version 0.22.0 prometheus/alertmanager#2393

Thank you. I have added the test. I have not worked with versions, let me see what I can add to preflights and push the changes.

@rezizter rezizter changed the title enhancement: Add time_intervals to AlertManager WIP:enhancement: Add time_intervals to AlertManager Nov 30, 2023
@rezizter rezizter force-pushed the alertmanager_time_intervals branch from ee0cbfb to 2a4cd46 Compare December 1, 2023 20:12
@rezizter rezizter changed the title WIP:enhancement: Add time_intervals to AlertManager enhancement: Add time_intervals to AlertManager Dec 1, 2023
@rezizter rezizter force-pushed the alertmanager_time_intervals branch from 526f17b to b021a29 Compare December 1, 2023 20:45
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 1, 2023
@rezizter
Copy link
Contributor Author

rezizter commented Dec 1, 2023

@gardar. I have added molecule testing, and a version check to preflight. Would you mind having a look when convenient, and advising if all is in order?

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 1, 2023
gardar
gardar approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gardar gardar requested a review from SuperQ December 12, 2023 12:46
@SuperQ SuperQ merged commit 6223e3b into prometheus-community:main Dec 12, 2023
242 checks passed
@gardar gardar mentioned this pull request Dec 12, 2023
Closed
@rezizter rezizter deleted the alertmanager_time_intervals branch December 13, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardar gardar gardar approved these changes

@SuperQ SuperQ Awaiting requested review from SuperQ

Assignees
No one assigned
Labels
enhancement New feature or request roles/alertmanager roles/blackbox_exporter roles/chrony_exporter roles/mysqld_exporter roles/node_exporter roles/prometheus roles/pushgateway roles/smartctl_exporter roles/smokeping_prober roles/snmp_exporter roles/systemd_exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rezizter @gardar @SuperQ