fix(molecule): don't contact galaxy api since requirements come from git #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardar
force-pushed
the
ci/dont-contact-galaxy
branch
from
4178fd3 to
5f016b8
Compare
gardar
force-pushed
the
ci/dont-contact-galaxy
branch
from
5f016b8 to
f7e145e
Compare
…test molecule wrapper Signed-off-by: gardar <[email protected]>
gardar
force-pushed
the
ci/dont-contact-galaxy
branch
from
f7e145e to
20a1cf4
Compare
SuperQ
approved these changes
Oct 27, 2023
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we had already avoided contacting the ansible galaxy api when switching requirements.yml over to git repos, but apparently molecule has a couple of ways it's installing dependencies, one which is controlled by the "dependency" key in the molecule config, and the other one that via the "prerun" option. The prerun uses ansible-compat and we can't pass any configuration to it, so the only option is to disable it.
By avoiding the galaxy api we can safely use older ansible versions which are incompatible with the ansible galaxy v3 api.
This should also speed up testing a bit, since we're not installing dependencies multiple times per run.