Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pushgateway role #127

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat: Add pushgateway role #127

merged 1 commit into from
Aug 16, 2023

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented May 31, 2023

Add role to manage the Prometheus Pushgateway.

@github-actions github-actions bot added the enhancement New feature or request label May 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@SuperQ SuperQ requested a review from gardar May 31, 2023 05:22
@SuperQ SuperQ force-pushed the superq/pushgateway branch from 9a23749 to 7fab3f3 Compare May 31, 2023 05:48
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels May 31, 2023
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add the integration tests, to ensure the CI runs molecule.

EDIT: we can take care of that in the CI, see: #135

@SuperQ SuperQ force-pushed the superq/pushgateway branch from 7fab3f3 to e4a9ddd Compare May 31, 2023 18:19
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels May 31, 2023
@SuperQ SuperQ force-pushed the superq/pushgateway branch from e4a9ddd to 61bffe7 Compare July 10, 2023 20:02
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 10, 2023
@SuperQ SuperQ force-pushed the superq/pushgateway branch from 61bffe7 to e007007 Compare July 10, 2023 20:05
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 10, 2023
@SuperQ SuperQ force-pushed the superq/pushgateway branch from e007007 to 9ecff2c Compare July 10, 2023 20:33
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 10, 2023
Add role to manage the Prometheus Pushgateway.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/pushgateway branch from 9ecff2c to c676915 Compare July 11, 2023 06:31
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@1b5a051). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             main      #127   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         3           
  Lines           ?        86           
  Branches        ?         6           
========================================
  Hits            ?        86           
  Misses          ?         0           
  Partials        ?         0           
Flag Coverage Δ
integration 100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@SuperQ SuperQ requested a review from gardar July 11, 2023 07:08
@gardar gardar merged commit e3e99f7 into main Aug 16, 2023
@gardar gardar deleted the superq/pushgateway branch August 16, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roles/pushgateway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants