Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node_exporter - Add test for ProtectHome #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented May 10, 2023

Add a tmpfs mount to the node_exporter testing to make sure ProtectHome is changed.

@SuperQ SuperQ force-pushed the superq/test_protecthome branch from b580aab to 2748123 Compare May 10, 2023 08:23
@github-actions github-actions bot added bugfix and removed bugfix labels May 10, 2023
@SuperQ SuperQ force-pushed the superq/test_protecthome branch from 2748123 to 18b128d Compare May 10, 2023 08:27
@github-actions github-actions bot added bugfix and removed bugfix labels May 10, 2023
@SuperQ SuperQ force-pushed the superq/test_protecthome branch from 18b128d to f9abfe7 Compare May 10, 2023 08:43
@github-actions github-actions bot added bugfix and removed bugfix labels May 10, 2023
@SuperQ SuperQ force-pushed the superq/test_protecthome branch from f9abfe7 to 37318d0 Compare May 10, 2023 09:01
@github-actions github-actions bot added bugfix and removed bugfix labels May 10, 2023
@SuperQ
Copy link
Contributor Author

SuperQ commented May 10, 2023

It seems like the tmpfs isn't included in the ansible_mounts fact. Will have to investigate that.

Add a tmpfs mount to the node_exporter testing to make sure ProtectHome
is changed.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/test_protecthome branch from 23ed1f9 to 39f6702 Compare October 27, 2023 20:33
@github-actions github-actions bot added bugfix and removed bugfix labels Oct 27, 2023
@github-actions
Copy link
Contributor

Docs Build 📝

Thank you for contribution!✨

The docs for this PR have been published here:
https://prometheus-community.github.io/ansible/pr/101

You can compare to the docs for the main branch here:
https://prometheus-community.github.io/ansible/branch/main

The docsite for this PR is also available for download as an artifact from this run:
https://github.com/prometheus-community/ansible/actions/runs/6671984792

File changes:

Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/ansible/ansible/docsbuild/base/alertmanager_role.html b/home/runner/work/ansible/ansible/docsbuild/head/alertmanager_role.html
index caa2685..b37117f 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/alertmanager_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/alertmanager_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.alertmanager role – Prometheus Alertmanager service<a class="headerlink" href="#prometheus-prometheus-alertmanager-role-prometheus-alertmanager-service" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/blackbox_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/blackbox_exporter_role.html
index 688884c..bdbf2e8 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/blackbox_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/blackbox_exporter_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.blackbox_exporter role – Deploy and manage Prometheus blackbox exporter<a class="headerlink" href="#prometheus-prometheus-blackbox-exporter-role-deploy-and-manage-prometheus-blackbox-exporter" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/chrony_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/chrony_exporter_role.html
index 35f02f9..9766181 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/chrony_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/chrony_exporter_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.chrony_exporter role – Prometheus Chrony Exporter<a class="headerlink" href="#prometheus-prometheus-chrony-exporter-role-prometheus-chrony-exporter" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/index.html b/home/runner/work/ansible/ansible/docsbuild/head/index.html
index 70783f7..4021d43 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/index.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/index.html
@@ -116,7 +116,7 @@
              
   <section id="prometheus-prometheus">
 <span id="plugins-in-prometheus-prometheus"></span><h1>Prometheus.Prometheus<a class="headerlink" href="#prometheus-prometheus" title="Link to this heading"></a></h1>
-<p>Collection version 0.7.1</p>
+<p>Collection version 0.8.0</p>
 <nav class="contents local" id="contents">
 <ul class="simple">
 <li><p><a class="reference internal" href="#description" id="id1">Description</a></p></li>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/mysqld_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/mysqld_exporter_role.html
index c354878..c30eea7 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/mysqld_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/mysqld_exporter_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.mysqld_exporter role – Prometheus MySQLd Exporter<a class="headerlink" href="#prometheus-prometheus-mysqld-exporter-role-prometheus-mysqld-exporter" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/node_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/node_exporter_role.html
index 94badaf..17e6817 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/node_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/node_exporter_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.node_exporter role – Prometheus Node Exporter<a class="headerlink" href="#prometheus-prometheus-node-exporter-role-prometheus-node-exporter" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/prometheus_role.html b/home/runner/work/ansible/ansible/docsbuild/head/prometheus_role.html
index 34f8709..b0bb0f9 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/prometheus_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/prometheus_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.prometheus role – Installs and configures prometheus<a class="headerlink" href="#prometheus-prometheus-prometheus-role-installs-and-configures-prometheus" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/pushgateway_role.html b/home/runner/work/ansible/ansible/docsbuild/head/pushgateway_role.html
index 56c1d92..f5c1081 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/pushgateway_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/pushgateway_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.pushgateway role – Prometheus Pushgateway<a class="headerlink" href="#prometheus-prometheus-pushgateway-role-prometheus-pushgateway" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/smartctl_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/smartctl_exporter_role.html
index c0f82ed..0adeacd 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/smartctl_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/smartctl_exporter_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.smartctl_exporter role – Prometheus Smartctl Exporter<a class="headerlink" href="#prometheus-prometheus-smartctl-exporter-role-prometheus-smartctl-exporter" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/smokeping_prober_role.html b/home/runner/work/ansible/ansible/docsbuild/head/smokeping_prober_role.html
index 120eb85..2823787 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/smokeping_prober_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/smokeping_prober_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.smokeping_prober role – Prometheus Smokeping Prober<a class="headerlink" href="#prometheus-prometheus-smokeping-prober-role-prometheus-smokeping-prober" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/snmp_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/snmp_exporter_role.html
index 00ebed6..d3eced1 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/snmp_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/snmp_exporter_role.html
@@ -130,7 +130,7 @@
 <h1>prometheus.prometheus.snmp_exporter role – Prometheus SNMP exporter<a class="headerlink" href="#prometheus-prometheus-snmp-exporter-role-prometheus-snmp-exporter" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>
diff --git a/home/runner/work/ansible/ansible/docsbuild/base/systemd_exporter_role.html b/home/runner/work/ansible/ansible/docsbuild/head/systemd_exporter_role.html
index 4d6f7b1..7465c34 100644
--- a/home/runner/work/ansible/ansible/docsbuild/base/systemd_exporter_role.html
+++ b/home/runner/work/ansible/ansible/docsbuild/head/systemd_exporter_role.html
@@ -129,7 +129,7 @@
 <h1>prometheus.prometheus.systemd_exporter role – Prometheus Systemd Exporter<a class="headerlink" href="#prometheus-prometheus-systemd-exporter-role-prometheus-systemd-exporter" title="Link to this heading"></a></h1>
 <div class="admonition note">
 <p class="admonition-title">Note</p>
-<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.7.1).</p>
+<p>This role is part of the <a class="reference external" href="https://galaxy.ansible.com/ui/repo/published/prometheus/prometheus/">prometheus.prometheus collection</a> (version 0.8.0).</p>
 <p>It is not included in <code class="docutils literal notranslate"><span class="pre">ansible-core</span></code>.
 To check whether it is installed, run <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">list</span></code>.</p>
 <p>To install it use: <code class="code docutils literal notranslate"><span class="pre">ansible-galaxy</span> <span class="pre">collection</span> <span class="pre">install</span> <span class="pre">prometheus.prometheus</span></code>.</p>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants