Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of o.t.containers.CassandraContainer + KafkaContainer #9680

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

snazy
Copy link
Member

@snazy snazy commented Oct 1, 2024

... in favor of org.testcontainers.cassandra.CassandraContainer and org.testcontainers.kafka.KafkaContainer. It seems that has been introduced by the testcontainers bump in #9675.

@snazy snazy force-pushed the fix-testcontainers-deprecation branch from ef561d5 to 30e21d0 Compare October 1, 2024 20:59
@snazy snazy changed the title Fix deprecation of o.t.containers.CassandraContainer Fix deprecation of o.t.containers.CassandraContainer + KafkaContainer Oct 1, 2024
@snazy snazy force-pushed the fix-testcontainers-deprecation branch from 30e21d0 to 9c076e2 Compare October 1, 2024 21:31
@snazy snazy marked this pull request as draft October 1, 2024 21:31
@snazy snazy force-pushed the fix-testcontainers-deprecation branch 2 times, most recently from 341fac8 to 74a9478 Compare October 1, 2024 22:00
@snazy snazy marked this pull request as ready for review October 1, 2024 22:03
dimas-b
dimas-b previously approved these changes Oct 1, 2024
snazy added 2 commits October 2, 2024 10:38
…ner`

... in favor of `org.testcontainers.cassandra.CassandraContainer` and `org.testcontainers.kafka.KafkaContainer`. It seems that has been introduced by the testcontainers bump in projectnessie#9675.
@snazy snazy force-pushed the fix-testcontainers-deprecation branch from 74a9478 to d3c8e8f Compare October 2, 2024 08:40
@snazy snazy requested a review from dimas-b October 2, 2024 09:05
@snazy snazy merged commit 83e6db3 into projectnessie:main Oct 2, 2024
16 checks passed
@snazy snazy deleted the fix-testcontainers-deprecation branch October 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants