Site: display download options for each artifact in tabs #8946

adutra · 2024-06-26T15:34:15Z

... also include more download options from Maven Central.

snazy

Funny, I tried this change initially, but wasn't happy with my own result. TL;DR the visual experience of the "tabs" was a bit annoying, because it's not immediately clear "that the tabs are actually tabs". Mind playing with the CSS for these and maybe make the inactive tabs appear with a light gray and the active tab with a bit darker gray?

snazy · 2024-06-27T12:54:12Z

site/docs/downloads/index.md

+    java -jar nessie-quarkus-{{ versions.nessie }}-runner.jar
+    ```
+
+=== "Maven Central"


Not sure whether Maven coordinates for a distributable are helpful. I suspect it would rather confuse people. Better remove those from here and elsewhere.

The Snapshot-Repo information on the in-dev/index.md is fine. Should be made clearer though that this is meant for developing against Nessie - but maybe also include the nessie-bom as an enforcedPlatform() for Gradle and <dependencyManagement> for Maven poms. Might also be helpful to add a similar section to the release downloads.

Not sure whether Maven coordinates for a distributable are helpful. I suspect it would rather confuse people.

If someone needs to build a custom Nessie server, e.g. to add more extensions, that's exactly the snippet they would need to include, no?

Anyways I removed the Maven Central tabs.

I also tried to implement all your suggestions (not sure I got all of them right.)

adutra · 2024-06-27T17:12:11Z

Funny, I tried this change initially, but wasn't happy with my own result. TL;DR the visual experience of the "tabs" was a bit annoying, because it's not immediately clear "that the tabs are actually tabs". Mind playing with the CSS for these and maybe make the inactive tabs appear with a light gray and the active tab with a bit darker gray?

Here is how it looks on my end right now. I find it nice in fact.

Here is what I could get:

Is that OK? Tested on Chrome for Mac and Safari for Mac.

snazy · 2024-06-27T17:30:05Z

Is that OK? Tested on Chrome for Mac and Safari for Mac.

Yea! That looks much better! You can now see that these are tabs and not just text or heading.

adutra · 2024-06-27T17:43:36Z

site/docs/stylesheets/extra.css

+  margin-right: 2px;
+}
+
+.md-typeset .tabbed-set>input:first-child:checked~.tabbed-labels>:first-child,


This is a bit disappointing, but there is no CSS class specific to selected tabs, so basically the stylesheet attempts to apply the style to the first 20 tabs of a tabset, but only if they are selected.

Oh - I see, it's because of the two distinct sets of elements.

Mind adding a comment that there are two sets of elements? It took me a while to realize that.

What do you mean by two sets? I count 20 rules. Are you referring to the next-sibling combinator ~?

The sets of input and label elements

snazy

Basically just one style suggestions, corrections to the group-ID and some enhancement proposals.

snazy · 2024-06-27T19:32:46Z

site/docs/downloads/index.md

+        </dependency>
+      </dependencies>
+    </dependencyManagement>
+    ```


Suggested change

```

```

Then you can use all Nessie artifacts like this:

```xml

<dependencies>

<dependency>

<groupId>org.projectnessie.nessie</groupId>

<artifactId>nessie-client</artifactId>

</dependency>

</dependencies>

```

snazy · 2024-06-27T19:32:58Z

site/docs/downloads/index.md

+    <dependencyManagement>
+      <dependencies>
+        <dependency>
+          <groupId>org.projectnessie</groupId>


Suggested change

<groupId>org.projectnessie</groupId>

<groupId>org.projectnessie.nessie</groupId>

snazy · 2024-06-27T19:33:14Z

site/docs/downloads/index.md

+    In your Gradle project's `build.gradle.kts` add the Nessie BOM as an enforced platform:
+    ```kotlin
+    dependencies {
+      enforcedPlatform("org.projectnessie:nessie-bom:{{ versions.nessie }}")


Suggested change

enforcedPlatform("org.projectnessie:nessie-bom:{{ versions.nessie }}")

enforcedPlatform("org.projectnessie.nessie:nessie-bom:{{ versions.nessie }}")

snazy · 2024-06-27T19:35:26Z

site/docs/downloads/index.md

+    dependencies {
+      enforcedPlatform("org.projectnessie:nessie-bom:{{ versions.nessie }}")
+    }
+    ```


Suggested change

```

```

A full example using the `nessie-client` artifact:

```kotlin

dependencies {

enforcedPlatform("org.projectnessie.nessie:nessie-bom:{{ versions.nessie }}")

implementation("org.projectnessie.nessie:nessie-client")

}

```

snazy · 2024-06-27T19:36:27Z

site/in-dev/index-release.md

+    dependencies {
+      enforcedPlatform("org.projectnessie:nessie-bom:::NESSIE_VERSION::")
+    }
+    ```


Suggested change

```

```

A full example using the `nessie-client` artifact:

```kotlin

dependencies {

enforcedPlatform("org.projectnessie.nessie:nessie-bom:::NESSIE_VERSION::")

implementation("org.projectnessie.nessie:nessie-client")

}

```

snazy · 2024-06-27T19:37:12Z

site/in-dev/index-release.md

+    In your Gradle project's `build.gradle.kts` add the Nessie BOM as an enforced platform:
+    ```kotlin
+    dependencies {
+      enforcedPlatform("org.projectnessie:nessie-bom:::NESSIE_VERSION::")


Suggested change

enforcedPlatform("org.projectnessie:nessie-bom:::NESSIE_VERSION::")

enforcedPlatform("org.projectnessie.nessie:nessie-bom:::NESSIE_VERSION::")

snazy · 2024-06-27T19:37:47Z

site/in-dev/index.md

+    <dependencyManagement>
+      <dependencies>
+        <dependency>
+          <groupId>org.projectnessie</groupId>


Suggested change

<groupId>org.projectnessie</groupId>

<groupId>org.projectnessie.nessie</groupId>

snazy · 2024-06-27T19:37:55Z

site/in-dev/index.md

+    In your Gradle project's `build.gradle.kts` add the Nessie BOM as an enforced platform:
+    ```kotlin
+    dependencies {
+      enforcedPlatform("org.projectnessie:nessie-bom:::NESSIE_VERSION::")


Suggested change

enforcedPlatform("org.projectnessie:nessie-bom:::NESSIE_VERSION::")

enforcedPlatform("org.projectnessie.nessie:nessie-bom:::NESSIE_VERSION::")

snazy · 2024-06-27T19:38:46Z

site/docs/stylesheets/extra.css

@@ -21,3 +21,31 @@ img.bordered {
 .md-typeset td code {
  word-break: revert;
 }
+


Mind adding this as well?

Suggested change

.md-typeset .tabbed-set>.tabbed-content {

padding: 0 .5em 0 .5em;

border: 1px solid #ababab;

border-bottom-left-radius: .3em;

border-bottom-right-radius: .3em;

}

Quite frankly I don't like it :-D but I added it nonetheless.

snazy · 2024-06-27T19:39:39Z

site/docs/stylesheets/extra.css

+  margin-right: 2px;
+}
+
+.md-typeset .tabbed-set>input:first-child:checked~.tabbed-labels>:first-child,


Oh - I see, it's because of the two distinct sets of elements.

Mind adding a comment that there are two sets of elements? It took me a while to realize that.

... also include more download options from Maven Central.

snazy · 2024-06-28T07:09:30Z

site/in-dev/index.md

@@ -59,20 +62,23 @@ Docker images are multiplatform images for amd64, arm64, ppc64le, s390x.
 [Nessie GC](/nessie-nightly/gc/) allows mark and sweep data files based on flexible
 expiration policies.

-### Docker image
+=== "Docker Image"


Looks like the CLI above needs this change as well

snazy reviewed Jun 27, 2024

View reviewed changes

adutra commented Jun 27, 2024

View reviewed changes

snazy reviewed Jun 27, 2024

View reviewed changes

adutra added 5 commits June 28, 2024 08:45

Site: display download options for each artifact in tabs

6d9c574

... also include more download options from Maven Central.

css tweak

b8569a2

review comments

5fb195e

remove Maven Central tabs

a88c0b9

capitalization

4b4f144

adutra force-pushed the site-tabs branch from 7b599e9 to 4b4f144 Compare June 28, 2024 06:49

adutra added 2 commits June 28, 2024 09:03

review comments

494202b

review comments

b36d876

snazy reviewed Jun 28, 2024

View reviewed changes

adutra added 2 commits June 28, 2024 09:17

missing tab

dc2dfb3

round tabs

3b74943

snazy approved these changes Jun 28, 2024

View reviewed changes

adutra merged commit c648800 into projectnessie:main Jun 28, 2024
18 checks passed

adutra deleted the site-tabs branch June 28, 2024 07:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Site: display download options for each artifact in tabs #8946

Site: display download options for each artifact in tabs #8946

adutra commented Jun 26, 2024

snazy left a comment

snazy Jun 27, 2024

adutra Jun 27, 2024

adutra Jun 27, 2024

adutra commented Jun 27, 2024

snazy commented Jun 27, 2024

adutra Jun 27, 2024

snazy Jun 27, 2024

adutra Jun 28, 2024

snazy Jun 28, 2024

snazy left a comment

snazy Jun 27, 2024

snazy Jun 27, 2024

snazy Jun 27, 2024

snazy Jun 27, 2024

snazy Jun 27, 2024

snazy Jun 27, 2024

snazy Jun 27, 2024

snazy Jun 27, 2024

snazy Jun 27, 2024

adutra Jun 28, 2024

snazy Jun 27, 2024

snazy Jun 28, 2024

	<groupId>org.projectnessie</groupId>
	<groupId>org.projectnessie.nessie</groupId>

	enforcedPlatform("org.projectnessie:nessie-bom:{{ versions.nessie }}")
	enforcedPlatform("org.projectnessie.nessie:nessie-bom:{{ versions.nessie }}")

-    ```
+    ```
+   A full example using the `nessie-client` artifact:
+    ```kotlin
+    dependencies {
+      enforcedPlatform("org.projectnessie.nessie:nessie-bom:{{ versions.nessie }}")
+      implementation("org.projectnessie.nessie:nessie-client")
+    }
+    ```

+.md-typeset .tabbed-set>.tabbed-content {
+  padding: 0 .5em 0 .5em;
+  border: 1px solid #ababab;
+  border-bottom-left-radius: .3em;
+  border-bottom-right-radius: .3em;
+}

Site: display download options for each artifact in tabs #8946

Site: display download options for each artifact in tabs #8946

Conversation

adutra commented Jun 26, 2024

snazy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adutra commented Jun 27, 2024

snazy commented Jun 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snazy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment