Helm chart: fix catalogStorageEnv template #8944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and a few other fixes: * configmap.yaml: remove extra whitespace * configmap.yaml: don't output `<nil>` when value is nil * deployment.yaml: use secretToEnv wherever possible * inmemory-values.yaml: fix placement of authCredentialsJsonSecret
dimas-b
approved these changes
Jun 26, 2024
snazy
reviewed
Jun 26, 2024
| @@ -129,28 +129,28 @@ data: | |||
|
|
|||
| {{- if .Values.catalog.enabled -}} | |||
| {{- list .Values.catalog.iceberg $map | include "nessie.applyCatalogIcebergOptions" -}} | |||
| {{ list .Values.catalog.storage.s3 "nessie.catalog.service.s3." $map | include "nessie.applyCatalogStorageS3RootOptions"}} | |||
| {{ list .Values.catalog.storage.s3.defaultOptions "nessie.catalog.service.s3.default-options." $map | include "nessie.applyCatalogStorageS3BucketOptions"}} | |||
| {{- list .Values.catalog.storage.s3 "nessie.catalog.service.s3." $map | include "nessie.applyCatalogStorageS3RootOptions" }} | |||
There was a problem hiding this comment.
What's the difference between these?
{{- list ... -}}
and
{{- list ... }}
and
{{ list ... }}
There was a problem hiding this comment.
whitespace control before and after the braces.
https://helm.sh/docs/chart_template_guide/control_structures/#controlling-whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and a few other fixes:
<nil>when value is nil