-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site: new placeholders for nightly version, tag and unstable suffix #8939
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,14 +27,9 @@ databases. | |
for production use. Any JDBC compliant database can be used, but it must be created and the | ||
schema initialized before running the Nessie GC tool. | ||
|
||
## Running locally | ||
## Running the standalone uber jar | ||
|
||
The Nessie GC tool can be downloaded from the [GitHub | ||
Releases](https://github.com/projectnessie/nessie/releases) page, for example: | ||
|
||
```shell | ||
curl -L -o nessie-gc.jar https://github.com/projectnessie/nessie/releases/download/nessie-::NESSIE_VERSION::/nessie-gc-::NESSIE_VERSION::.jar | ||
``` | ||
Check download options in the [Nessie download page](../downloads/index.md). | ||
|
||
To see the available commands and options, run: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's keep this line separate. |
||
|
||
|
@@ -92,7 +87,7 @@ docker run --rm -e POSTGRES_USER=pguser -e POSTGRES_PASSWORD=mysecretpassword -e | |
Create the database schema if required: | ||
|
||
```shell | ||
docker run --rm ghcr.io/projectnessie/nessie-gc:::NESSIE_VERSION:: create-sql-schema \ | ||
docker run --rm ghcr.io/projectnessie/nessie-gc::NESSIE_DOCKER_SUFFIX:: create-sql-schema \ | ||
--jdbc-url jdbc:postgresql://127.0.0.1:5432/nessie_gc \ | ||
--jdbc-user pguser \ | ||
--jdbc-password mysecretpassword | ||
|
@@ -101,16 +96,16 @@ docker run --rm ghcr.io/projectnessie/nessie-gc:::NESSIE_VERSION:: create-sql-sc | |
Now we can run the Nessie GC tool: | ||
|
||
```shell | ||
docker run --rm ghcr.io/projectnessie/nessie-gc:::NESSIE_VERSION:: gc \ | ||
docker run --rm ghcr.io/projectnessie/nessie-gc::NESSIE_DOCKER_SUFFIX:: gc \ | ||
--jdbc-url jdbc:postgresql://127.0.0.1:5432/nessie_gc \ | ||
--jdbc-user pguser \ | ||
--jdbc-password mysecretpassword | ||
``` | ||
|
||
The GC tool has a great number of options, which can be seen by running `docker run --rm | ||
ghcr.io/projectnessie/nessie-gc:::NESSIE_VERSION:: --help`. The main command is `gc`, which is followed by | ||
subcommands and options. Check the available subcommands and options by running `docker run --rm | ||
ghcr.io/projectnessie/nessie-gc:::NESSIE_VERSION:: gc --help`. | ||
ghcr.io/projectnessie/nessie-gc::NESSIE_DOCKER_SUFFIX:: --help`. The main command is `gc`, | ||
which is followed by subcommands and options. Check the available subcommands and options by running | ||
`docker run --rm ghcr.io/projectnessie/nessie-gc::NESSIE_DOCKER_SUFFIX:: gc --help`. | ||
|
||
## Running with Kubernetes | ||
|
||
|
@@ -142,7 +137,7 @@ spec: | |
spec: | ||
containers: | ||
- name: nessie-gc | ||
image: ghcr.io/projectnessie/nessie-gc:::NESSIE_VERSION:: | ||
image: ghcr.io/projectnessie/nessie-gc::NESSIE_DOCKER_SUFFIX:: | ||
args: | ||
- gc | ||
- --uri | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this SO question, the syntax
-i=''
should be portable across different OSes (just-i
gives an error on macOS).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work, yes