Add SecretsProvider implementations for AWS, GCP, Vault
#8707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
secrets-impls
branch
7 times, most recently
from
cfff958 to
8ed4df3
Compare
dimas-b
previously approved these changes
Jun 7, 2024
...crets/cache/src/main/java/org/projectnessie/catalog/secrets/cache/CachingSecretsBackend.java
Outdated
Show resolved
Hide resolved
snazy
force-pushed
the
secrets-impls
branch
3 times, most recently
from
973308c to
c009c6b
Compare
snazy
force-pushed
the
secrets-impls
branch
10 times, most recently
from
8cc8ab8 to
b6a7594
Compare
snazy
force-pushed
the
secrets-impls
branch
3 times, most recently
from
5a3b4da to
a94351c
Compare
snazy
force-pushed
the
secrets-impls
branch
2 times, most recently
from
e8cf0e1 to
db73994
Compare
snazy
force-pushed
the
secrets-impls
branch
5 times, most recently
from
95e5e80 to
c1901a8
Compare
snazy
changed the title
SecretsSupplier implementations for AWS, GCP, VaultSecretsProvider implementations for AWS, GCP, Vault
snazy
force-pushed
the
secrets-impls
branch
2 times, most recently
from
8cf5d64 to
d2344e0
Compare
snazy
force-pushed
the
secrets-impls
branch
2 times, most recently
from
6ff59f2 to
07a0b9f
Compare
snazy
force-pushed
the
secrets-impls
branch
6 times, most recently
from
629ff18 to
3a665e5
Compare
dimas-b
reviewed
Sep 9, 2024
catalog/secrets/aws/src/main/java/org/projectnessie/catalog/secrets/aws/AwsSecretsManager.java
Outdated
Show resolved
Hide resolved
| k -> { | ||
| @SuppressWarnings("unchecked") | ||
| Optional<Secret> loaded = | ||
| (Optional<Secret>) backend.getSecret(name, secretType, secretJavaType); |
There was a problem hiding this comment.
backend.getSecret() can block... Are we ok with that?
dimas-b
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.