Minor doc enhancements around authentication providers #7710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
previously approved these changes
Nov 13, 2023
site/docs/develop/java.md
Outdated
| @@ -210,18 +210,46 @@ The documentation for how to configure Nessie server authentication can be found | |||
| The `BasicAuthenticationProvider` allows connecting to a Nessie server that has `BASIC` authentication enabled. | |||
| Note that `BASIC` is not supported in production and should only be used for development/testing. | |||
There was a problem hiding this comment.
I believe servers (outside of unit tests) do not allow "basic" auth at all. Cf. this in applicaiton.properties:
# fixed at buildtime
quarkus.http.auth.basic=false
Would you mind fixing this doc paragraph too?
There was a problem hiding this comment.
I think we can remove references to BASIC auth from all docs at this point. WDYT?
adutra
commented
Nov 14, 2023
| "https://<oidc-server>/realms/<realm-name>/protocol/openid-connect/token", | ||
| CONF_NESSIE_OAUTH2_CLIENT_ID, "my_client_id", | ||
| CONF_NESSIE_OAUTH2_CLIENT_SECRET, "very_secret"); | ||
| NessieApiV2 api = |
There was a problem hiding this comment.
I noticed incidentally when creating this example that the programmatic configuration of the OAuth2 provider is convoluted. There is no easy factory method available, and OAuth2Client and OAuth2ClientParams are package-private.
Should we improve that? (In a separate PR, of course.)
dimas-b
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.