-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace validation for rename operation #7650
Conversation
...ts/src/main/java/org/projectnessie/spark/extensions/AbstractNessieSparkSqlExtensionTest.java
Outdated
Show resolved
Hide resolved
@@ -132,6 +132,28 @@ public void testRefreshAfterMergeWithIcebergTableCaching() | |||
.containsExactlyInAnyOrder(row(23, "test"), row(24, "test24")); | |||
} | |||
|
|||
@Test | |||
public void testRenameTableToMissingNamespace() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is way "too far away" from the changed code. A test needs to be in :nessie-versioned-storage-common-tests
- such a test must also verify that the identified-key for CommitValidator
works in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test missing / wrong place.
I tried adding a test in
But it seems it is not going to the place where I fixed. I am not very familiar with that part of the code now. It would take too much time for me to understand it now. |
I should fetch the content from the backend to use it for rename. Without that reusing the content object in the test class will be considered as new content as it is not having content id. Fixed now. |
1f59493
to
b72229a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add an entry to CHANGELOG.md.
...ioned/tests/src/main/java/org/projectnessie/versioned/tests/AbstractNamespaceValidation.java
Outdated
Show resolved
Hide resolved
Namespace validation happens before the |
Fixes #7645