Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.6 #6536

Merged
merged 1 commit into from
May 10, 2024
Merged

Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.6 #6536

merged 1 commit into from
May 10, 2024

Conversation

snazy
Copy link
Member

@snazy snazy commented Apr 8, 2023 •
edited
Loading

  • For nessie-client: slf4j 1.7 + logback 1.3
  • For Spark related: slf4j 1.7 + logback 1.3
  • Other modules: slf4j 2.0 + logback 1.5

Fixes #5216

@snazy snazy marked this pull request as draft April 8, 2023 09:40
adutra
adutra reviewed Apr 11, 2023
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@snazy snazy force-pushed the slf4j2-logback13 branch 2 times, most recently from 86de521 to 3a1ab2b Compare April 27, 2023 17:14
@snazy
Copy link
Member Author

snazy commented Apr 27, 2023

Oh, nice - Spark triggers ClassNotFoundExceptions by using internal SLF4J classes🤦

  private def isLog4j12(): Boolean = {
    // This distinguishes the log4j 1.2 binding, currently
    // org.slf4j.impl.Log4jLoggerFactory, from the log4j 2.0 binding, currently
    // org.apache.logging.slf4j.Log4jLoggerFactory
    val binderClass = StaticLoggerBinder.getSingleton.getLoggerFactoryClassStr
    "org.slf4j.impl.Log4jLoggerFactory".equals(binderClass)
  }

@snazy snazy force-pushed the slf4j2-logback13 branch 3 times, most recently from b3a92f6 to b439f7e Compare June 6, 2023 15:31
@snazy snazy force-pushed the slf4j2-logback13 branch 2 times, most recently from 7998e79 to 849cf1b Compare June 13, 2023 13:15
@snazy snazy changed the title Bump slf4j to 2.0.7 + logback to 1.3.6 Bump slf4j to 2.0.7 + logback to 1.3.7/1.4.7 Jun 13, 2023
@snazy snazy changed the title Bump slf4j to 2.0.7 + logback to 1.3.7/1.4.7 Bump slf4j to 1.7.36/2.0.7 + logback to 1.3.7/1.4.7 Jun 13, 2023
@snazy snazy force-pushed the slf4j2-logback13 branch from 849cf1b to 00e5ee1 Compare June 15, 2023 10:47
@snazy snazy force-pushed the slf4j2-logback13 branch 3 times, most recently from e2fda88 to 2917671 Compare June 28, 2023 06:53
@snazy snazy force-pushed the slf4j2-logback13 branch 3 times, most recently from 53c69e6 to cfc26d2 Compare July 10, 2023 07:52
@snazy snazy force-pushed the slf4j2-logback13 branch 3 times, most recently from 778740a to f71ce95 Compare July 17, 2023 09:51
@snazy snazy force-pushed the slf4j2-logback13 branch 3 times, most recently from 8ef4d1c to dcd6b43 Compare July 25, 2023 14:58
@snazy snazy force-pushed the slf4j2-logback13 branch 3 times, most recently from 76bfed0 to 674b486 Compare August 7, 2023 07:46
@snazy snazy force-pushed the slf4j2-logback13 branch 2 times, most recently from 6368ef6 to cce094e Compare August 10, 2023 07:17
@snazy snazy changed the title Bump slf4j to 1.7.36/2.0.11 + logback to 1.3.14/1.4.14 Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.4.14 Mar 12, 2024
@snazy snazy changed the title Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.4.14 Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.3 Mar 12, 2024
@snazy snazy force-pushed the slf4j2-logback13 branch 3 times, most recently from b0253a4 to 053858e Compare March 15, 2024 09:52
@snazy snazy force-pushed the slf4j2-logback13 branch 2 times, most recently from 15942c1 to 8421db8 Compare March 25, 2024 16:12
@snazy snazy force-pushed the slf4j2-logback13 branch 2 times, most recently from e1e74fd to 226f18d Compare April 3, 2024 13:23
@snazy snazy force-pushed the slf4j2-logback13 branch 2 times, most recently from 3dfc1bd to bee120a Compare April 9, 2024 14:43
@snazy snazy changed the title Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.3 Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.4 Apr 9, 2024
@snazy snazy force-pushed the slf4j2-logback13 branch from bee120a to 1a5acc3 Compare April 12, 2024 17:08
@snazy snazy changed the title Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.4 Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.5 Apr 12, 2024
@snazy snazy force-pushed the slf4j2-logback13 branch from 1a5acc3 to 5c0c8ab Compare April 18, 2024 07:01
@snazy snazy changed the title Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.5 Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.6 Apr 18, 2024
@snazy snazy force-pushed the slf4j2-logback13 branch from 5c0c8ab to 6f96dbc Compare April 22, 2024 16:08
@snazy snazy force-pushed the slf4j2-logback13 branch 4 times, most recently from 0113486 to d32f758 Compare May 6, 2024 08:26
@snazy snazy force-pushed the slf4j2-logback13 branch from d32f758 to 415754c Compare May 10, 2024 10:25
@snazy
Bump slf4j to 1.7.36/2.0.12 + logback to 1.3.14/1.5.6
182524b 
* For nessie-client, nessie-services, Spark integrations projects: slf4j 1.7.x (those modules to not expose logback as a runtime dependency)
* Other modules: slf4j 2.0.x + logback 1.5.x
@snazy snazy force-pushed the slf4j2-logback13 branch from 415754c to 182524b Compare May 10, 2024 10:35
@snazy snazy added the pr-integrations NesQuEIT (Iceberg, Spark, Flink, Presto) label May 10, 2024
@snazy snazy marked this pull request as ready for review May 10, 2024 10:36
@snazy snazy requested a review from dimas-b May 10, 2024 10:36
@snazy snazy merged commit 8b90b54 into projectnessie:main May 10, 2024
19 of 31 checks passed
@snazy snazy deleted the slf4j2-logback13 branch May 10, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adutra adutra adutra left review comments

@dimas-b dimas-b dimas-b approved these changes

Assignees
No one assigned
Labels
pr-integrations NesQuEIT (Iceberg, Spark, Flink, Presto)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate upgrade of logback and slf4j
3 participants
@snazy @adutra @dimas-b