Fix cache-deserialization for UpdateableObj (#8815)

projectnessie · Jun 13, 2024 · ab04281 · ab04281
1 parent 0450690
commit ab04281
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/...alize/src/main/java/org/projectnessie/versioned/storage/serialize/ProtoSerialization.java b/...alize/src/main/java/org/projectnessie/versioned/storage/serialize/ProtoSerialization.java
@@ -297,7 +297,10 @@ public static Obj deserializeObjProto(ObjId id, ObjProto obj, String versionToke
       return deserializeUniqueId(id, obj.getUniqueId());
     }
     if (obj.hasCustom()) {
-      return deserializeCustom(id, obj.getCustom(), versionToken);
+      return deserializeCustom(
+          id,
+          obj.getCustom(),
+          versionToken != null ? versionToken : obj.getCustom().getVersionToken());
     }
     throw new UnsupportedOperationException("Cannot deserialize " + obj);
   }
@@ -506,9 +509,14 @@ private static UniqueIdProto.Builder serializeUniqueId(UniqueIdObj obj) {
 
   private static Obj deserializeCustom(ObjId id, CustomProto custom, String versionToken) {
     ObjType type = ObjTypes.forShortName(custom.getObjType());
+    if (versionToken == null) {
+      // versionToken is set when reading objects from the database, but cache-deserialization has
+      // the versionToken in the object
+      versionToken = custom.getVersionToken();
+    }
     return SmileSerialization.deserializeObj(
         id,
-        versionToken != null ? versionToken : custom.getVersionToken(),
+        versionToken,
         custom.getData().toByteArray(),
         type.targetClass(),
         custom.getCompression().name());