Skip to content

Commit

Permalink
Update docker.io/scylladb/scylla Docker tag to v6 (#9397)
Browse files Browse the repository at this point in the history 
* Update docker.io/scylladb/scylla Docker tag to v6

* Adopt test code

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Robert Stupp <[email protected]>
  • Loading branch information
@renovate @snazy
renovate[bot] and snazy authored Aug 23, 2024
1 parent e6fddf3 commit 8894ef0
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 17 deletions.
28 changes: 14 additions & 14 deletions site/in-dev/configuration.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,20 +189,20 @@ Related Quarkus settings:

### Support for the database specific implementations

| Database | Status | Configuration value for `nessie.version.store.type` | Notes |
|------------------|--------------------------------------------------|---------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| "in memory" | only for development and local testing | `IN_MEMORY` | Do not use for any serious use case. |
| RocksDB | production, single node only | `ROCKSDB` | |
| Google BigTable | production | `BIGTABLE` | |
| MongoDB | production | `MONGODB` | |
| Amazon DynamoDB | beta, only tested against the simulator | `DYNAMODB` | Not recommended for use with Nessie Catalog (Iceberg REST) due to its restrictive row-size limit. |
| PostgreSQL | production | `JDBC` | |
| H2 | only for development and local testing | `JDBC` | Do not use for any serious use case. |
| MariaDB | experimental, feedback welcome | `JDBC` | |
| MySQL | experimental, feedback welcome | `JDBC` | Works by connecting the MariaDB driver to a MySQL server. |
| CockroachDB | experimental, known issues | `JDBC` | Known to raise user-facing "write too old" errors under contention. |
| Apache Cassandra | experimental, known issues | `CASSANDRA` | Known to raise user-facing errors due to Cassandra's concept of letting the driver timeout too early, or database timeouts. |
| ScyllaDB | experimental, known issues | `CASSANDRA` | Known to raise user-facing errors due to Cassandra's concept of letting the driver timeout too early, or database timeouts. Known to be slow in container based testing. Unclear how good Scylla's LWT implementation performs. |
| Database | Status | Configuration value for `nessie.version.store.type` | Notes |
|------------------|--------------------------------------------------|---------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| "in memory" | only for development and local testing | `IN_MEMORY` | Do not use for any serious use case. |
| RocksDB | production, single node only | `ROCKSDB` | |
| Google BigTable | production | `BIGTABLE` | |
| MongoDB | production | `MONGODB` | |
| Amazon DynamoDB | beta, only tested against the simulator | `DYNAMODB` | Not recommended for use with Nessie Catalog (Iceberg REST) due to its restrictive row-size limit. |
| PostgreSQL | production | `JDBC` | |
| H2 | only for development and local testing | `JDBC` | Do not use for any serious use case. |
| MariaDB | experimental, feedback welcome | `JDBC` | |
| MySQL | experimental, feedback welcome | `JDBC` | Works by connecting the MariaDB driver to a MySQL server. |
| CockroachDB | experimental, known issues | `JDBC` | Known to raise user-facing "write too old" errors under contention. |
| Apache Cassandra | experimental, known issues | `CASSANDRA` | Known to raise user-facing errors due to Cassandra's concept of letting the driver timeout too early, or database timeouts. |
| ScyllaDB | experimental, known issues | `CASSANDRA` | Known to raise user-facing errors due to Cassandra's concept of letting the driver timeout too early, or database timeouts. Known to be slow in container based testing. Unclear how good Scylla's LWT implementation performs. With Scylla version 6, you need to use a keyspace with "tablets" disabled. |

!!! note
Relational databases are generally slower and tend to become a bottleneck when concurrent Nessie commits against
Expand Down
8 changes: 6 additions & 2 deletions ...g/projectnessie/versioned/storage/cassandratests/AbstractCassandraBackendTestFactory.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,14 @@ private void maybeCreateKeyspace(CqlSession session) {
.map(dc -> format("'%s': %d", dc, replicationFactor))
.collect(Collectors.joining(", "));

// Disable tablets in ScyllaDB, because those are not compatible with LWTs (yet?). See
// https://opensource.docs.scylladb.com/stable/architecture/tablets.html#limitations-and-unsupported-features
String scyllaClause = "scylladb".equals(dbName) ? " AND tablets = {'enabled': false}" : "";

session.execute(
format(
"CREATE KEYSPACE IF NOT EXISTS %s WITH replication = {'class': 'NetworkTopologyStrategy', %s};",
KEYSPACE_FOR_TEST, datacenters));
"CREATE KEYSPACE IF NOT EXISTS %s WITH replication = {'class': 'NetworkTopologyStrategy', %s}%s;",
KEYSPACE_FOR_TEST, datacenters, scyllaClause));
session.refreshSchema();
}

Expand Down
2 changes: 1 addition & 1 deletion .../resources/org/projectnessie/versioned/storage/cassandratests/Dockerfile-scylladb-version
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Dockerfile to provide the image name and tag to a test.
# Version is managed by Renovate - do not edit.
FROM docker.io/scylladb/scylla:5.4.9
FROM docker.io/scylladb/scylla:6.1.0

0 comments on commit 8894ef0

Please sign in to comment.